apache
Fix terms, typos and grammar mistakes in the API, error messages, events, etc.
Description
This PR aligns the use of terminology, renaming VM / virtual machine references to 'Instance' and also capitalising the terms Templates, Network, Snapshot, User, Account in CloudStack APIs, error and log messages, events, tooltips, etc. Many typos, grammar and spelling mistakes were fixed, also terms like IPv4, VPN, VPC, etc. were properly capitalised. Some error messages were cleaned for better readability. The test cases, expecting some exception strings were adjusted accordingly.
Here is the wiki page, describing the changes in details: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Object+Naming+and+Title+Case+Convention
Types of changes
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
Screenshots (if appropriate):
None
How Has This Been Tested?
This change has been tested locally using the simulator hypervisor plugin.
Codecov Report
:x: Patch coverage is 13.57143% with 121 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 16.18%. Comparing base (243f566) to head (e0fa2f4).
:warning: Report is 1 commits behind head on 4.20.
Additional details and impacted files
@@ Coverage Diff @@
## 4.20 #7857 +/- ##
============================================
- Coverage 16.18% 16.18% -0.01%
+ Complexity 13301 13298 -3
============================================
Files 5657 5657
Lines 498473 498478 +5
Branches 60501 60501
============================================
- Hits 80663 80658 -5
- Misses 408830 408836 +6
- Partials 8980 8984 +4
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.00% <ø> (ø) |
|
| unittests | 17.03% <13.57%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sudo87 [SL] I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups]
Mgmt OS options: ['ol8', 'ol9', 'debian12', 'rocky8', 'alma9', 'suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-debian12', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'vmware-80u2', 'vmware-80u3', 'vmware-80u3e', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xenserver-84', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82', 'xcpng83']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced)
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.
Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar', 'sudo87', 'rosi-shapeblue']
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14680
@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14937
@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
[SF] Trillian test result (tid-14280) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 75938 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7857-t14280-kvm-ol8.zip Smoke tests completed. 138 look OK, 8 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| ContextSuite context=TestMigrateVMStrictTags>:setup | Error |
0.00 | test_vm_strict_host_tags.py |
| ContextSuite context=TestRestoreVMStrictTags>:setup | Error |
0.00 | test_vm_strict_host_tags.py |
| ContextSuite context=TestScaleVMStrictTags>:setup | Error |
0.00 | test_vm_strict_host_tags.py |
| ContextSuite context=TestVMDeploymentPlannerStrictTags>:setup | Error |
0.00 | test_vm_strict_host_tags.py |
| test_06_download_detached_volume | Error |
314.98 | test_volumes.py |
| ContextSuite context=TestVolumes>:teardown | Error |
125.11 | test_volumes.py |
| test_04_deploy_vnf_appliance | Error |
311.76 | test_vnf_templates.py |
| ContextSuite context=TestIpv6Vpc>:setup | Error |
0.00 | test_vpc_ipv6.py |
| ContextSuite context=TestVPCRedundancy>:setup | Error |
0.00 | test_vpc_redundant.py |
| ContextSuite context=TestVPCNics>:setup | Error |
0.00 | test_vpc_router_nics.py |
| ContextSuite context=TestRVPCSite2SiteVpn>:setup | Error |
0.00 | test_vpc_vpn.py |
| ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | Error |
0.00 | test_vpc_vpn.py |
| ContextSuite context=TestVpcRemoteAccessVpn>:setup | Error |
0.00 | test_vpc_vpn.py |
| ContextSuite context=TestVpcSite2SiteVpn>:setup | Error |
0.00 | test_vpc_vpn.py |
| test_disable_oobm_ha_state_ineligible | Error |
1516.47 | test_hostha_kvm.py |
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15022
