cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

It is not possible to make network redundant in the UI

Open soreana opened this issue 2 years ago • 14 comments

ISSUE TYPE
  • Bug Report
COMPONENT NAME
UI
CLOUDSTACK VERSION
Main
SUMMARY

Is is not possible to restart the network and make it redundant by the UI, although it is possible to do so using the CloudMonkey. I guess its button is hidden below the Live patch network's router option.

(localcloud) 🐱 > restart network makeredundant=true id=88ef836e-9e3d-4705-aed6-575e6e8ed9ee cleanup=true
{
  "success": true
}
(localcloud) 🐱 >

Screenshot 2023-02-17 at 23 56 52

STEPS TO REPRODUCE
1. Create an isolated network in advanced zone
2. Try to restart it and make it redundant
EXPECTED RESULTS
In the restart pop up there is a switch to turn on the redundant option
ACTUAL RESULTS
In the restart pop up there is "not" an option to make the network redundant.

soreana avatar Feb 17 '23 23:02 soreana

@DaanHoogland Please add this one to the 4.18 milestone.

soreana avatar Feb 17 '23 23:02 soreana

@soreana I remember this has been removed from a previous version (on UI). maybe @rohityadavcloud knows

weizhouapache avatar Feb 18 '23 07:02 weizhouapache

@weizhouapache Yes, I couldn't see this option in the 4.17 as well.

Is there any reason behind that? Using the command line is the only way to make a network redundant?

soreana avatar Feb 18 '23 09:02 soreana

@soreana I think this was discussed before and intentionally removed, the argument was that if a router needs to be redundant it must be determined by it's offering, not an option in the UI, since it takes resources. I think the option is still there with the API

borisstoyanov avatar Feb 20 '23 10:02 borisstoyanov

@borisstoyanov Thanks Bobby for explanation. 👍 Yes, it is possible to make router redundant using the restart network API call but the option has been removed from the UI. I was wondering why, by any chance do you have the mailing thread, or the related issue?

soreana avatar Feb 20 '23 10:02 soreana

I've tried searching the PR but couldn't get it, sorry

borisstoyanov avatar Feb 20 '23 10:02 borisstoyanov

No problem, thanks ;)

soreana avatar Feb 20 '23 10:02 soreana

@borisstoyanov @soreana this is related to #4052

weizhouapache avatar Feb 20 '23 11:02 weizhouapache

@weizhouapache Thanks Wei.

That really makes sense. The redundancy is a property of the network, it is not the action. When we reset the network it should check the network properties and configure them accordingly.

Btw, I don't think that the service offering is a place where we should add these settings. In the https://github.com/apache/cloudstack/pull/6918 PR, I've added the network level configurations (Actually most of the codes were written by Wei 😃). Shall I add the redundant network level setting later as well?

soreana avatar Feb 20 '23 12:02 soreana

clearing this from milestonne 4.18 @soreana . hope you agree.

DaanHoogland avatar Feb 20 '23 12:02 DaanHoogland

clearing this from milestonne 4.18 @soreana . hope you agree.

@DaanHoogland Of course, it was irrelevant. ;)

soreana avatar Feb 20 '23 12:02 soreana

@weizhouapache Thanks Wei.

That really makes sense. The redundancy is a property of the network, it is not the action. When we reset the network it should check the network properties and configure them accordingly.

Btw, I don't think that the service offering is a place where we should add these settings. In the #6918 PR, I've added the network level configurations (Actually most of the codes were written by Wei smiley). Shall I add the redundant network level setting later as well?

@soreana Each network has a property redundant (check networks table in cloud database). The field will be updated if change the network offering or restart network with makeredundant=true

I understand the use case described #4052, my concerns are

  • users can still make network redandant via API restartNetwork
  • should the action be disabled for root admin as well ?

weizhouapache avatar Feb 21 '23 09:02 weizhouapache

Please refer to https://github.com/apache/cloudstack/pull/7405#issuecomment-1537850131 and as others have mentioned https://github.com/apache/cloudstack/issues/4052

This is actually my fault, I had added this in the UI which we later agreed to remove (see reasons on the above links). If it's a much needed feature than we must introduce a global setting and keep it false to not show the option and let the admin/operator decide on the behaviour.

rohityadavcloud avatar May 08 '23 08:05 rohityadavcloud

Thanks @weizhouapache and @rohityadavcloud for the feedback.

I'm totally agree with you that it is not necessary feature. I will discuss it with my team and get back to your.

Btw, there is another way to manage this. In the https://github.com/apache/cloudstack/pull/6918, I've added network level settings. We can have another setting to make network redundant. Let me know your thought about it.

soreana avatar May 08 '23 10:05 soreana