[VMware] apply IOPS in resize/migrate

[SadiJr]

trafficstars

Description

Using the VMware hypervisor, when migrating/resizing one volume, with or without IOPS limitation, and changing the disk offering, this volume keeps the configurations of IOPS of the original offering, only applying the new configurations when detaching and attaching the volume. This PR aims to fix this behavior, to apply the new IOPS configuration when migration/resizing a volume changing the disk offering.

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [x] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

It was tested in a local lab:

1. I created a new VM, and three new disk offerings, one without IOPS limitation, the second with 3000 IOPS limitation, and the third with 5000 IOPS limitation;
2. I tested migrate/resize this VM volume, using all the three new disk offerings;
3. Before the changes, the VM definition in vCenter did not have its IOPS configuration changed;
4. Now, the VM definition in vCenter has its IOPS configuration changed.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 88 lines in your changes missing coverage. Please review.

Project coverage is 16.60%. Comparing base (41b4f0a) to head (1684347). Report is 31 commits behind head on main.

Files with missing lines	Patch %	Lines
...oud/hypervisor/vmware/resource/VmwareResource.java	0.00%	34 Missing :warning:
...m/cloud/agent/api/storage/ResizeVolumeCommand.java	0.00%	12 Missing :warning:
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	9 Missing and 3 partials :warning:
...ck/storage/motion/VmwareStorageMotionStrategy.java	0.00%	7 Missing :warning:
.../cloud/agent/api/storage/MigrateVolumeCommand.java	0.00%	6 Missing :warning:
...tack/storage/motion/AncientDataMotionStrategy.java	0.00%	6 Missing :warning:
...stack/engine/orchestration/VolumeOrchestrator.java	0.00%	5 Missing :warning:
...m/cloud/hypervisor/vmware/mo/VirtualMachineMO.java	0.00%	3 Missing :warning:
...e/driver/CloudStackPrimaryDataStoreDriverImpl.java	0.00%	2 Missing :warning:
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	0.00%	1 Missing :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #7226      +/-   ##
============================================
+ Coverage     16.57%   16.60%   +0.02%     
- Complexity    13870    13924      +54     
============================================
  Files          5719     5730      +11     
  Lines        507200   508166     +966     
  Branches      61574    61783     +209     
============================================
+ Hits          84093    84384     +291     
- Misses       413688   414345     +657     
- Partials       9419     9437      +18     

Flag	Coverage Δ
uitests	3.93% <ø> (-0.03%)	:arrow_down:
unittests	17.49% <0.00%> (+0.04%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

[github-actions[bot]]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[shwstppr]

@SadiJr can you please check the review comments

[github-actions[bot]]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7542

[DaanHoogland]

@SadiJr can you answer any questions/address any comments, please?

[DaanHoogland]

ping @SadiJr

[SadiJr]

@DaanHoogland Sorry for the delay, I will review the comments and work on this PR.

[github-actions[bot]]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[BryanMLima]

As @SadiJr is focusing in other tasks, I will be working on this PR.

[sureshanaparti]

Hi @SadiJr Can target this PR for 4.19.1?

[BryanMLima]

@blueorangutan package

[blueorangutan]

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8929

[github-actions[bot]]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[BryanMLima]

@blueorangutan package

[blueorangutan]

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9336

[sureshanaparti]

Hi @SadiJr Please check & address the outstanding comments. Thanks.

[BryanMLima]

Hi @SadiJr Please check & address the outstanding comments. Thanks.

Hey @sureshanaparti, I'm trying to address the comments and validate the PR, however, I'm having trouble with my VMware environment at the moment. I hope to address all of them before the code freeze.

[BryanMLima]

@blueorangutan package

[blueorangutan]

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10785

[BryanMLima]

@sureshanaparti can you trigger the tests here?

[BryanMLima]

@weizhouapache, can you check if all your concerns are met?

[DaanHoogland]

@blueorangutan test alma9 vmware-70u3

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests