Ova download fix

[DaanHoogland]

Description

This PR allows for downloading OVA with the read properties from OVF flag when the OVF does not contain a minimum hardware version.

Fixes: #6736

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [x] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [x] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

by downloading an OVA that does not provide a minimum hardware version and making sure it is accepted.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6758 (SL-JID-2403)

[blueorangutan]

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4245

[codecov[bot]]

Codecov Report

Merging #6758 (37b5548) into main (65c7070) will increase coverage by 4.73%. The diff coverage is 0.00%.

:exclamation: Current head 37b5548 differs from pull request most recent head 77ec01c. Consider uploading reports for the commit 77ec01c to get more accurate results

@@             Coverage Diff              @@
##               main    #6758      +/-   ##
============================================
+ Coverage      5.88%   10.62%   +4.73%     
- Complexity     3942     6869    +2927     
============================================
  Files          2454     2466      +12     
  Lines        242723   244565    +1842     
  Branches      37988    38277     +289     
============================================
+ Hits          14289    25974   +11685     
+ Misses       226850   215309   -11541     
- Partials       1584     3282    +1698     

Impacted Files	Coverage Δ
...om/cloud/storage/dao/GuestOSHypervisorDaoImpl.java	32.25% <0.00%> (-0.36%)	:arrow_down:
...storage/image/deployasis/DeployAsIsHelperImpl.java	13.26% <0.00%> (-0.21%)	:arrow_down:
...rce/wrapper/LibvirtResizeVolumeCommandWrapper.java	49.50% <0.00%> (-27.17%)	:arrow_down:
.../cloud/hypervisor/kvm/storage/KVMPhysicalDisk.java	70.27% <0.00%> (-10.98%)	:arrow_down:
...pper/LibvirtPrepareForMigrationCommandWrapper.java	43.10% <0.00%> (-7.97%)	:arrow_down:
...rg/apache/cloudstack/quota/QuotaStatementImpl.java	36.28% <0.00%> (-3.99%)	:arrow_down:
...loud/hypervisor/kvm/resource/LibvirtSecretDef.java	60.00% <0.00%> (-3.16%)	:arrow_down:
.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java	10.48% <0.00%> (-2.63%)	:arrow_down:
...apache/cloudstack/storage/volume/VolumeObject.java	35.75% <0.00%> (-2.61%)	:arrow_down:
...vm/resource/wrapper/LibvirtStopCommandWrapper.java	42.66% <0.00%> (-1.78%)	:arrow_down:
... and 539 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-5014) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 11465 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6758-t5014-vmware-67u3.zip Smoke tests completed. 13 look OK, 1 have errors, 89 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_isolate_network_FW_PF_default_routes_egress_true	Error	981.10	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	Error	0.01	test_routers_network_ops.py
ContextSuite context=TestIsolatedNetworks>:teardown	Error	0.01	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	Error	0.03	test_routers_network_ops.py
all_test_accounts	Skipped	---	test_accounts.py
all_test_persistent_network	Skipped	---	test_persistent_network.py
all_test_affinity_groups	Skipped	---	test_affinity_groups.py
all_test_migration	Skipped	---	test_migration.py
all_test_affinity_groups_projects	Skipped	---	test_affinity_groups_projects.py
all_test_router_dnsservice	Skipped	---	test_router_dnsservice.py
all_test_annotations	Skipped	---	test_annotations.py
all_test_routers	Skipped	---	test_routers.py
all_test_async_job	Skipped	---	test_async_job.py
all_test_multipleips_per_nic	Skipped	---	test_multipleips_per_nic.py
all_test_attach_multiple_volumes	Skipped	---	test_attach_multiple_volumes.py
all_test_nested_virtualization	Skipped	---	test_nested_virtualization.py
all_test_backup_recovery_dummy	Skipped	---	test_backup_recovery_dummy.py
all_test_portable_publicip	Skipped	---	test_portable_publicip.py
all_test_certauthority_root	Skipped	---	test_certauthority_root.py
all_test_portforwardingrules	Skipped	---	test_portforwardingrules.py
all_test_console_endpoint	Skipped	---	test_console_endpoint.py
all_test_internal_lb	Skipped	---	test_internal_lb.py
all_test_network	Skipped	---	test_network.py
all_test_deploy_vgpu_enabled_vm	Skipped	---	test_deploy_vgpu_enabled_vm.py
all_test_network_acl	Skipped	---	test_network_acl.py
all_test_deploy_virtio_scsi_vm	Skipped	---	test_deploy_virtio_scsi_vm.py
all_test_privategw_acl	Skipped	---	test_privategw_acl.py
all_test_deploy_vm_iso	Skipped	---	test_deploy_vm_iso.py
all_test_privategw_acl_ovs_gre	Skipped	---	test_privategw_acl_ovs_gre.py
all_test_deploy_vm_iso_uefi	Skipped	---	test_deploy_vm_iso_uefi.py
all_test_network_permissions	Skipped	---	test_network_permissions.py
all_test_deploy_vm_root_resize	Skipped	---	test_deploy_vm_root_resize.py
all_test_nic	Skipped	---	test_nic.py
all_test_usage	Skipped	---	test_usage.py
all_test_deploy_vm_with_userdata	Skipped	---	test_deploy_vm_with_userdata.py
all_test_diagnostics	Skipped	---	test_diagnostics.py
all_test_projects	Skipped	---	test_projects.py
all_test_direct_download	Skipped	---	test_direct_download.py
all_test_public_ip_range	Skipped	---	test_public_ip_range.py
all_test_disk_offerings	Skipped	---	test_disk_offerings.py
all_test_non_contigiousvlan	Skipped	---	test_non_contigiousvlan.py
all_test_disk_provisioning_types	Skipped	---	test_disk_provisioning_types.py
all_test_outofbandmanagement	Skipped	---	test_outofbandmanagement.py
all_test_domain_disk_offerings	Skipped	---	test_domain_disk_offerings.py
all_test_outofbandmanagement_nestedplugin	Skipped	---	test_outofbandmanagement_nestedplugin.py
all_test_domain_network_offerings	Skipped	---	test_domain_network_offerings.py
all_test_over_provisioning	Skipped	---	test_over_provisioning.py
all_test_domain_service_offerings	Skipped	---	test_domain_service_offerings.py
all_test_pvlan	Skipped	---	test_pvlan.py
all_test_domain_vpc_offerings	Skipped	---	test_domain_vpc_offerings.py
all_test_scale_vm	Skipped	---	test_scale_vm.py
all_test_dynamicroles	Skipped	---	test_dynamicroles.py
all_test_ipv6_infra	Skipped	---	test_ipv6_infra.py
all_test_vm_life_cycle	Skipped	---	test_vm_life_cycle.py
all_test_enable_account_settings_for_domain	Skipped	---	test_enable_account_settings_for_domain.py
all_test_iso	Skipped	---	test_iso.py
all_test_secondary_storage	Skipped	---	test_secondary_storage.py
all_test_enable_role_based_users_in_projects	Skipped	---	test_enable_role_based_users_in_projects.py
all_test_regions	Skipped	---	test_regions.py
all_test_events_resource	Skipped	---	test_events_resource.py
all_test_password_server	Skipped	---	test_password_server.py
all_test_gateway_on_shared_networks	Skipped	---	test_gateway_on_shared_networks.py
all_test_reset_configuration_settings	Skipped	---	test_reset_configuration_settings.py
all_test_global_settings	Skipped	---	test_global_settings.py
all_test_reset_vm_on_reboot	Skipped	---	test_reset_vm_on_reboot.py
all_test_guest_vlan_range	Skipped	---	test_guest_vlan_range.py
all_test_resource_accounting	Skipped	---	test_resource_accounting.py
all_test_service_offerings	Skipped	---	test_service_offerings.py
all_test_resource_detail	Skipped	---	test_resource_detail.py
all_test_hostha_simulator	Skipped	---	test_hostha_simulator.py
all_test_human_readable_logs	Skipped	---	test_human_readable_logs.py
all_test_kubernetes_clusters	Skipped	---	test_kubernetes_clusters.py
all_test_login	Skipped	---	test_login.py
all_test_snapshots	Skipped	---	test_snapshots.py
all_test_kubernetes_supported_versions	Skipped	---	test_kubernetes_supported_versions.py
all_test_router_dhcphosts	Skipped	---	test_router_dhcphosts.py
all_test_list_ids_parameter	Skipped	---	test_list_ids_parameter.py
all_test_ssvm	Skipped	---	test_ssvm.py
all_test_loadbalance	Skipped	---	test_loadbalance.py
all_test_metrics_api	Skipped	---	test_metrics_api.py
all_test_vm_snapshots	Skipped	---	test_vm_snapshots.py
all_test_routers_iptables_default_policy	Skipped	---	test_routers_iptables_default_policy.py
all_test_storage_policy	Skipped	---	test_storage_policy.py
all_test_update_security_group	Skipped	---	test_update_security_group.py
all_test_vm_lifecycle_unmanage_import	Skipped	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_snapshot_kvm	Skipped	---	test_vm_snapshot_kvm.py
all_test_volumes	Skipped	---	test_volumes.py
all_test_vpc_ipv6	Skipped	---	test_vpc_ipv6.py
all_test_vpc_redundant	Skipped	---	test_vpc_redundant.py
all_test_vpc_router_nics	Skipped	---	test_vpc_router_nics.py
all_test_vpc_vpn	Skipped	---	test_vpc_vpn.py
all_test_host_maintenance	Skipped	---	test_host_maintenance.py
all_test_hostha_kvm	Skipped	---	test_hostha_kvm.py

[blueorangutan]

Trillian test result (tid-5021) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43459 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6758-t5021-vmware-67u3.zip Smoke tests completed. 102 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	764.42	test_kubernetes_clusters.py

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4293

[DaanHoogland]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-5031) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43658 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6758-t5031-vmware-67u3.zip Smoke tests completed. 102 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	694.44	test_kubernetes_clusters.py

[DaanHoogland]

@borisstoyanov @nvazquez can you please look at this?

[borisstoyanov]

@blueorangutan test centos7 vmware-67u3 keepEnv

[borisstoyanov]

Sure @DaanHoogland, will do.

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6758 (SL-JID-2430)

[borisstoyanov]

@blueorangutan test centos7 vmware-67u3 keepEnv

[blueorangutan]

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-5051) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44143 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6758-t5051-vmware-67u3.zip Smoke tests completed. 102 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	627.03	test_kubernetes_clusters.py

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6758 (SL-JID-2493)

[DaanHoogland]

@blueorangutan package