cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Warning statement for SetMonitorServiceCommand command sent to VR due to additional answers received

Open rohityadavcloud opened this issue 3 years ago • 4 comments

Unnecessary warning statement was seen for SetMonitorServiceCommand command sent to VR (for health checks), as 3 answer sent but one expected:

2022-09-21 12:39:34,773 WARN [resource.virtualnetwork.VirtualRoutingResource] (agentRequest-Handler-4:null) (logid:d5969a8f) Expected 1 answers while executing SetMonitorServiceCommand but received 3 2022-09-21 12:39:34,775 DEBUG [cloud.agent.Agent] (agentRequest-Handler-4:null) (logid:d5969a8f) Seq 214-1179380152417660442: { Ans: , MgmtId: 12345, via: 214, Ver: v1, Flags: 10, [{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null - success: Creating file in VR, with ip: a.b.c.d, file: monitor_service.json.1d4987b3-85ef-481a-8d48-33b5b853fa5e","null - success: ","null - success: "],"result":"true","wait":"0","bypassHostMaintenance":"false"}}] }

ISSUE TYPE
  • Bug Report
COMPONENT NAME
VR

rohityadavcloud avatar Sep 22 '22 06:09 rohityadavcloud

@rohityadavcloud I think a warning is in place here, why do you think this is a bug?

DaanHoogland avatar Sep 22 '22 06:09 DaanHoogland

The bug is perhaps why 3 things are returned and not just one. (what's with the "null - success: ","null - success: "])

rohityadavcloud avatar Sep 22 '22 06:09 rohityadavcloud

any reproduction scheme/situation in which you ran into this?

DaanHoogland avatar Sep 22 '22 07:09 DaanHoogland

Nope, just deploy an advn zone env with VMs on VPC and isolated networks and track this command. (This is a minor low-hanging fruit issue, perhaps something in the script parsing the output is taking the unnecessary results and throwing back as null - success)

rohityadavcloud avatar Sep 22 '22 08:09 rohityadavcloud

investigating:

  • an empty vpc does not yield this error.
  • an isolated network with only 1 vm doe not trigger the superfluent answers either…
  • starting a vm in the tier of the vpc does not trigger it.

DaanHoogland avatar Oct 24 '22 13:10 DaanHoogland

fixed in #7050

DaanHoogland avatar Jan 24 '23 08:01 DaanHoogland