cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

fix description of configuration `max.data.migration.wait.time`

Open GaOrtiga opened this issue 2 years ago • 3 comments

Description

Currently the description of the configuration max.data.migration.wait.time does not specify which time unity is used (minutes). The goal of this PR is to add this information to the description.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

  • [ ] Major
  • [X] Minor

How Has This Been Tested?

I built the code with the changes and applied it in a local lab. After starting cloudstack-management.service, the configuration description changed to the new one.

GaOrtiga avatar Sep 19 '22 17:09 GaOrtiga

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points:

  • In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
  • Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
  • Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
  • Be sure to read the CloudStack Coding Conventions. Apache CloudStack is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] (https://cloudstack.apache.org/mailing-lists.html) Slack: https://apachecloudstack.slack.com/

boring-cyborg[bot] avatar Sep 19 '22 17:09 boring-cyborg[bot]

Codecov Report

Merging #6749 (23d0b07) into main (bbc1260) will increase coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #6749   +/-   ##
=========================================
  Coverage     10.42%   10.42%           
- Complexity     6701     6705    +4     
=========================================
  Files          2458     2458           
  Lines        243246   243246           
  Branches      38067    38067           
=========================================
+ Hits          25358    25366    +8     
+ Misses       214714   214704   -10     
- Partials       3174     3176    +2     
Impacted Files Coverage Δ
...rc/main/java/com/cloud/storage/StorageManager.java 76.92% <ø> (ø)
...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 62.60% <0.00%> (ø)
...apache/cloudstack/syslog/AlertsSyslogAppender.java 58.75% <0.00%> (+2.25%) :arrow_up:
...dstack/network/contrail/model/ModelObjectBase.java 28.84% <0.00%> (+7.69%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 20 '22 09:09 codecov[bot]

Awesome work, congrats on your first merged pull request!

boring-cyborg[bot] avatar Sep 24 '22 18:09 boring-cyborg[bot]