cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Fix of template size when setup CS with StorPool as a primary storage

Open slavkap opened this issue 2 years ago • 2 comments

Description

In the newer versions of CS, the template size is null until the Secondary storage VM isn't created. This leads to NullPointerException, and CS cannot create a volume for the VM. We'll now save the real size of the template, and we'll get it from the template_spool_ref table

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [X] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Fresh install 2 Zones with 5 agents on KVM

slavkap avatar Sep 13 '22 12:09 slavkap

Codecov Report

Merging #6735 (566d7e1) into main (48ffa5d) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #6735   +/-   ##
=========================================
  Coverage     10.84%   10.84%           
  Complexity     7097     7097           
=========================================
  Files          2485     2485           
  Lines        245366   245364    -2     
  Branches      38318    38317    -1     
=========================================
  Hits          26606    26606           
+ Misses       215491   215489    -2     
  Partials       3269     3269           
Impacted Files Coverage Δ
...rapper/StorPoolDownloadTemplateCommandWrapper.java 0.00% <0.00%> (ø)
...tastore/driver/StorPoolPrimaryDataStoreDriver.java 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 13 '22 15:09 codecov[bot]

@blueorangutan package

rohityadavcloud avatar Oct 08 '22 06:10 rohityadavcloud

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 08 '22 06:10 blueorangutan

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4382

blueorangutan avatar Oct 08 '22 09:10 blueorangutan