cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

[GSOC] OAuth feature addition

Open neogismm opened this issue 3 years ago • 2 comments

Description

This PR is to add functionality for OAuth 2.0 authentication with Google as IDP. Continuation of #6524

Progress:

  • [x] Obtain client id/secret from Google API console
  • [x] Create a Util class for the core methods
  • [x] Create a Servlet class that handles redirect URLs for a successful or failed auth flow
  • [x] Method to check if the user is already logged in
  • [ ] Check if the user is a new or existing user (implement checking methods with cloudstack database)
  • [x] Logout method
  • [ ] Make changes in UI

NB: Progress milestones to be added/edited as I grow my understanding of the codebase.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [x] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

neogismm avatar Sep 07 '22 07:09 neogismm

Codecov Report

Merging #6713 (2f0087e) into main (687a21c) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #6713      +/-   ##
============================================
- Coverage      5.90%    5.89%   -0.01%     
+ Complexity     3946     3945       -1     
============================================
  Files          2454     2464      +10     
  Lines        242749   242867     +118     
  Branches      37991    37999       +8     
============================================
- Hits          14325    14323       -2     
- Misses       226839   226960     +121     
+ Partials       1585     1584       -1     
Impacted Files Coverage Δ
...rg/apache/cloudstack/oauth2/OAuth2AuthManager.java 0.00% <0.00%> (ø)
...pache/cloudstack/oauth2/OAuth2AuthManagerImpl.java 0.00% <0.00%> (ø)
...che/cloudstack/oauth2/OAuth2UserAuthenticator.java 0.00% <0.00%> (ø)
...java/org/apache/cloudstack/oauth2/OAuth2Utils.java 0.00% <0.00%> (ø)
...stack/oauth2/api/command/AuthorizeOauthSSOCmd.java 0.00% <0.00%> (ø)
...ack/oauth2/api/response/OauthProviderResponse.java 0.00% <0.00%> (ø)
...dstack/oauth2/googleAuth/LoginCallbackServlet.java 0.00% <0.00%> (ø)
...che/cloudstack/oauth2/googleAuth/LoginServlet.java 0.00% <0.00%> (ø)
...he/cloudstack/oauth2/googleAuth/LogoutServlet.java 0.00% <0.00%> (ø)
...e/cloudstack/oauth2/googleAuth/ProfileServlet.java 0.00% <0.00%> (ø)
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 07 '22 09:09 codecov[bot]

@neogismm cc @harikrishna-patnala is this still relevant with the new PR #7996 ?

shwstppr avatar Oct 03 '23 09:10 shwstppr

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Oct 31 '23 08:10 github-actions[bot]

@neogismm @harikrishna-patnala , can we close this?

DaanHoogland avatar Oct 31 '23 08:10 DaanHoogland

@neogismm @harikrishna-patnala I am closing this as #7996 is merged. Please reopen or create a new PR if anything else needs addressing.

DaanHoogland avatar Oct 31 '23 14:10 DaanHoogland