cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Added new logs to volume creation

Open JoaoJandre opened this issue 2 years ago • 8 comments

Description

This PR improves and adds new logs to volume creation to facilitate future troubleshooting.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [X] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

This was tested in a local lab, by creating volumes and checking if the logs were all correct.

JoaoJandre avatar Aug 30 '22 11:08 JoaoJandre

Codecov Report

Merging #6689 (d55af5c) into main (201f066) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #6689   +/-   ##
=========================================
  Coverage      5.87%    5.87%           
  Complexity     3934     3934           
=========================================
  Files          2454     2454           
  Lines        242683   242680    -3     
  Branches      37978    37958   -20     
=========================================
  Hits          14261    14261           
+ Misses       226843   226840    -3     
  Partials       1579     1579           
Impacted Files Coverage Δ
...stack/engine/orchestration/VolumeOrchestrator.java 0.00% <0.00%> (ø)
...torage/allocator/AbstractStoragePoolAllocator.java 9.24% <0.00%> (-0.45%) :arrow_down:
...ge/allocator/ClusterScopeStoragePoolAllocator.java 0.00% <0.00%> (ø)
...locator/GarbageCollectingStoragePoolAllocator.java 0.00% <0.00%> (ø)
...k/storage/allocator/LocalStoragePoolAllocator.java 0.00% <0.00%> (ø)
...torage/allocator/ZoneWideStoragePoolAllocator.java 0.00% <0.00%> (ø)
...cloud/storage/resource/VmwareStorageProcessor.java 0.32% <0.00%> (ø)
.../storage/allocator/RandomStoragePoolAllocator.java 0.00% <0.00%> (ø)
...java/com/cloud/hypervisor/vmware/mo/ClusterMO.java 0.25% <0.00%> (+<0.01%) :arrow_up:
...oud/hypervisor/vmware/mo/HypervisorHostHelper.java 15.33% <0.00%> (ø)
... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 30 '22 12:08 codecov[bot]

@blueorangutan package

DaanHoogland avatar Sep 12 '22 09:09 DaanHoogland

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 12 '22 09:09 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4171

blueorangutan avatar Sep 12 '22 10:09 blueorangutan

@blueorangutan test

DaanHoogland avatar Sep 12 '22 10:09 DaanHoogland

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Sep 12 '22 10:09 blueorangutan

Trillian test result (tid-4873) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42542 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6689-t4873-kvm-centos7.zip Smoke tests completed. 101 look OK, 0 have errors Only failed tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Sep 12 '22 22:09 blueorangutan

Merging this one based in the approvals and test results.

GutoVeronezi avatar Sep 26 '22 22:09 GutoVeronezi