Add message upon network offering creation to warn user of VR creation

[BryanMLima]

Description

This PR aims to improve the user experience upon creation of Network Offerings warning the user of the scenarios in which a VR is created. For this, the service offering field is always shown in the form and a warning message is displayed if the user's configuration does not require the creation of a VR. These scenarios include a network offering with guest type L2, and a with a guest type Shared or Isolated when none of the following services are enabled: (VPN, DHCP, DNS, Firewall, LB, UserData, SourceNat, StaticNat and/or PortForwarding). Finally, the message for the Isolated and Shared networks disappear when one of the aforementioned services are selected.

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [x] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

Message if the guest type is Isolated or Shared:

Message if the guest type is L2:

How Has This Been Tested?

This was tested in a local lab using the networking offering form. The message for Shared/Isolated type was only displayed if the none of the following services (VPN, DHCP, DNS, Firewall, LB, UserData, SourceNat, StaticNat and/or PortForwarding) were not selected. For the L2 message, it was always displayed, unless the guest type was changed.

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6684 (SL-JID-2246)

[codecov[bot]]

Codecov Report

Merging #6684 (02092d8) into main (9f7e0cc) will decrease coverage by 0.00%. The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #6684      +/-   ##
============================================
- Coverage      5.87%    5.87%   -0.01%     
+ Complexity     3936     3934       -2     
============================================
  Files          2454     2454              
  Lines        242683   242683              
  Branches      37978    37978              
============================================
- Hits          14265    14261       -4     
- Misses       226839   226843       +4     
  Partials       1579     1579              

Impacted Files	Coverage Δ
...apache/cloudstack/syslog/AlertsSyslogAppender.java	56.49% <0.00%> (-2.26%)	:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

code looks good I cannot login to the qa server to test this.

Error
Exception caught while discovering features.

cc @rohityadavcloud @davidjumani

[rohityadavcloud]

@blueorangutan ui

[blueorangutan]

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6684 (SL-JID-2474)