plugin-storage-volume-linstor: support QoS(IOPs) and small improvements

[rp-]

Description

This PR has 3 improvements for the Linstor primary storage driver:

• Create a separate jar of it and move all Linstor related classes into the correct project (similar to the storpool plugin)
• Add aux properties for Cloudstack volumes in Linstor to make it easier to identify them in Linstor
• Add support for IOPs settings with the Linstor storage plugin

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [x] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Local test cluster with the Linstor primary storage driver in place. Creating VMs and volumes and moving them between different disk-offerings.

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6682 (SL-JID-2242)

[codecov[bot]]

Codecov Report

Merging #6682 (7ccd121) into main (d9dd4c1) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #6682      +/-   ##
============================================
- Coverage     10.52%   10.52%   -0.01%     
  Complexity     6784     6784              
============================================
  Files          2464     2464              
  Lines        243988   244044      +56     
  Branches      38185    38198      +13     
============================================
  Hits          25690    25690              
- Misses       215065   215121      +56     
  Partials       3233     3233              

Impacted Files	Coverage Δ
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java	0.00% <0.00%> (ø)
...oud/hypervisor/kvm/storage/LinstorStoragePool.java	0.00% <ø> (ø)
...tore/driver/LinstorPrimaryDataStoreDriverImpl.java	0.00% <0.00%> (ø)
...ifecycle/LinstorPrimaryDataStoreLifeCycleImpl.java	0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rohityadavcloud]

@rp- can you check the security hotspot?

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6682 (SL-JID-2363)

[rp-]

@rohityadavcloud btw. I fixed the secuirty hotspot

[rohityadavcloud]

Thanks @rp- @blueorangutan package

[blueorangutan]

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4228

[github-actions[bot]]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[DaanHoogland]

@rp- can you look at the conflicts?

[rp-]

@DaanHoogland done and weird, because I just had todo a local rebase. no conflicts.

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6682 (SL-JID-2429)

[DaanHoogland]

SonarCloud Quality Gate failed.

2 Bugs 0 Vulnerabilities 0 Security Hotspots 13 Code Smells

0.0% Coverage 2.8% Duplication

@rp- looks mostly good but can you assess these ^^ I think some of them are easy to resolve. Of the bugs ignore the first one but please fix the second (potential NPE)

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6682 (SL-JID-2433)

[rp-]

@DaanHoogland done, even though the NPE was a false positive (but also my IDEA complained about it)

[blueorangutan]

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4311

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[rp-]

Packaging result: heavy_check_mark el7 heavy_check_mark el8 heavy_multiplication_x debian heavy_check_mark suse15. SL-JID 4311

@rohityadavcloud is that debian packaging error my fault? where could I look up the error?

[rohityadavcloud]

I think it's some intermittent pkging error @rp- I'll rekick them again. @blueorangutan package