cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Published 20 hours ago • verified publisher icon apache

Feature x

Open Yashikaone opened this issue 2 years ago • 7 comments

Description

This PR intends to build new functionality

If true safeshutdown will be triggered; if false completion will be awaited and system will be prepared for shutdown with the help of PrepareForShutdown api, this will not only monitor in_progress asynchronous jobs and wait for its completion and prevent addition of new asynchronous jobs.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Yashikaone avatar Aug 22 '22 08:08 Yashikaone

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Aug 22 '22 09:08 github-actions[bot]

Hi @Yashikaone thanks for your PR, I can see your changes on the second commit, however the first commit is not needed since there are no changes on it, can you please amend the PR to reflect only your changes?

nvazquez avatar Aug 22 '22 10:08 nvazquez

@nvazquez Sure , I'll find a way to fix that. Can you look into the changes and let me know how can I get this correct? Thanks! I can't reflect the changes made in QueryManagerImpl.java file, seems strange.

Yashikaone avatar Aug 22 '22 13:08 Yashikaone

@Yashikaone , you should completely remove commit ce70939f3a3aeb9d0c7f0dda10aa5e531c461691 from your PR. As the current status is you can do that by entering the command git rebase -i HEAD~5 and then in the editor you get presented remove the line for that commit from the file. Git will remnove the commit. After the complete procedure check the result. You can then git push -- force and the commit with all the empty changes will be gone.

DaanHoogland avatar Aug 23 '22 07:08 DaanHoogland

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 26 '22 06:08 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 26 '22 06:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6662 (SL-JID-2231)

blueorangutan avatar Aug 26 '22 06:08 blueorangutan

This was superseeded by https://github.com/apache/cloudstack/pull/6755 closing on this remark. Thanks for the PR.

rohityadavcloud avatar Apr 19 '23 07:04 rohityadavcloud