cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Enable live volume migration between StorPool's primary storages

Open slavkap opened this issue 2 years ago • 14 comments

Description

Migrating volumes live between two StorPool's primary storages doesn't make changes in the XML of the domain. It only updates the information into StorPool

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [X] Minor

How Has This Been Tested?

CS version - main branch hypervisors - KVM primary storage - 2 Zone-wide StorPool's primary storages

slavkap avatar Aug 21 '22 15:08 slavkap

Codecov Report

Merging #6661 (3ef378a) into main (20306d6) will decrease coverage by 0.71%. The diff coverage is 0.00%.

:exclamation: Current head 3ef378a differs from pull request most recent head 18853ce. Consider uploading reports for the commit 18853ce to get more accurate results

@@             Coverage Diff              @@
##               main    #6661      +/-   ##
============================================
- Coverage     11.58%   10.87%   -0.72%     
+ Complexity     7548     7115     -433     
============================================
  Files          2494     2485       -9     
  Lines        247089   245531    -1558     
  Branches      38615    38340     -275     
============================================
- Hits          28630    26695    -1935     
- Misses       214714   215567     +853     
+ Partials       3745     3269     -476     
Impacted Files Coverage Δ
...rapper/StorPoolDownloadTemplateCommandWrapper.java 0.00% <0.00%> (ø)
...e/wrapper/StorPoolModifyStorageCommandWrapper.java 0.00% <0.00%> (ø)
...hypervisor/kvm/storage/StorPoolStorageAdaptor.java 0.00% <0.00%> (ø)
...tastore/driver/StorPoolPrimaryDataStoreDriver.java 0.00% <0.00%> (ø)
...orage/datastore/provider/StorPoolHostListener.java 0.00% <0.00%> (ø)
...loudstack/storage/datastore/util/StorPoolUtil.java 0.00% <0.00%> (ø)
...k/storage/snapshot/StorPoolVMSnapshotStrategy.java 0.00% <0.00%> (ø)
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 12.84% <0.00%> (-0.18%) :arrow_down:
...ava/com/cloud/network/as/AutoScaleManagerImpl.java 0.12% <0.00%> (-56.36%) :arrow_down:
...ache/cloudstack/affinity/AffinityGroupVMMapVO.java 0.00% <0.00%> (-55.56%) :arrow_down:
... and 315 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 21 '22 18:08 codecov[bot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 25 '22 07:08 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 25 '22 07:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6661 (SL-JID-2220)

blueorangutan avatar Aug 25 '22 07:08 blueorangutan

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 25 '22 10:08 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 25 '22 10:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6661 (SL-JID-2222)

blueorangutan avatar Aug 25 '22 10:08 blueorangutan

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 29 '22 12:08 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 29 '22 12:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6661 (SL-JID-2240)

blueorangutan avatar Aug 29 '22 12:08 blueorangutan

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 29 '22 12:08 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 29 '22 12:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6661 (SL-JID-2241)

blueorangutan avatar Aug 29 '22 12:08 blueorangutan

@blueorangutan package

rohityadavcloud avatar Oct 08 '22 06:10 rohityadavcloud

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 08 '22 06:10 blueorangutan

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4385

blueorangutan avatar Oct 08 '22 09:10 blueorangutan

@blueorangutan package

rohityadavcloud avatar Oct 09 '22 09:10 rohityadavcloud

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 09 '22 09:10 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4398

blueorangutan avatar Oct 09 '22 11:10 blueorangutan

@blueorangutan package

nvazquez avatar Oct 09 '22 13:10 nvazquez

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 09 '22 13:10 blueorangutan

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4401

blueorangutan avatar Oct 09 '22 14:10 blueorangutan

@blueorangutan package

rohityadavcloud avatar Oct 09 '22 14:10 rohityadavcloud

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 09 '22 14:10 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4405

blueorangutan avatar Oct 09 '22 15:10 blueorangutan

@blueorangutan test

rohityadavcloud avatar Oct 09 '22 16:10 rohityadavcloud

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Oct 09 '22 16:10 blueorangutan

Trillian test result (tid-5094) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44316 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6661-t5094-kvm-centos7.zip Smoke tests completed. 103 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 540.54 test_kubernetes_clusters.py

blueorangutan avatar Oct 10 '22 04:10 blueorangutan

@slavkap is this ready for review/merge?

DaanHoogland avatar Oct 11 '22 14:10 DaanHoogland