cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

ui: reset disksize param on offering change in scale vm

Open shwstppr opened this issue 3 years ago • 3 comments

Description

Fixes #6627

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

shwstppr avatar Aug 12 '22 05:08 shwstppr

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 12 '22 05:08 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 12 '22 05:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6636 (SL-JID-2134)

blueorangutan avatar Aug 12 '22 06:08 blueorangutan

Codecov Report

Merging #6636 (e00ced7) into 4.17 (76f52af) will increase coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.17    #6636   +/-   ##
=========================================
  Coverage      5.86%    5.86%           
- Complexity     3918     3920    +2     
=========================================
  Files          2451     2451           
  Lines        242256   242256           
  Branches      37907    37907           
=========================================
+ Hits          14207    14211    +4     
+ Misses       226479   226475    -4     
  Partials       1570     1570           
Impacted Files Coverage Δ
...apache/cloudstack/syslog/AlertsSyslogAppender.java 58.75% <0.00%> (+2.25%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 12 '22 08:08 codecov[bot]

The problem is still present on Cloudstack 4.17.1.0.

Sometime it works, sometimes not, and i can't reproduce a test scenario where it always work or always fail : The only thing i can see is the called URL with developpers tools on firefox : 'https://*/client/api/?id=38a18b83-5583-4a8f-85a6-58ab45ec8c88&serviceofferingid=93fa5ed3-58e1-4d8d-9e34-573b1239215e&automigrate=true&command=scaleVirtualMachine&response=json -> Working correctly

https://*/client/api/?id=38a18b83-5583-4a8f-85a6-58ab45ec8c88&serviceofferingid=21cfe66f-d8a9-46b3-b3be-2eb7656fd2cb&automigrate=true&details[0].rootdisksize=0&command=scaleVirtualMachine&response=json -> Not working

All our serviceofferring are identical, only RAM and vcpu is different between them.

atmaniak avatar Sep 26 '22 12:09 atmaniak