server: fix delete resource tag permission

[shwstppr]

Description

Fixes #6623 Thi PR fixes resource tag deletion behaviour. The permission check should be done only for the tags that are passed in the API call instead of checking for all the tags for the resource.

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [ ] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3968

[codecov[bot]]

Codecov Report

Merging #6634 (a8e891f) into 4.17 (76f52af) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.17    #6634      +/-   ##
============================================
- Coverage      5.86%    5.86%   -0.01%     
  Complexity     3918     3918              
============================================
  Files          2451     2451              
  Lines        242256   242262       +6     
  Branches      37907    37908       +1     
============================================
  Hits          14207    14207              
- Misses       226479   226485       +6     
  Partials       1570     1570              

Impacted Files	Coverage Δ
...java/com/cloud/tags/TaggedResourceManagerImpl.java	0.00% <0.00%> (ø)
...ervisor/kvm/resource/LibvirtComputingResource.java	15.98% <0.00%> (-0.01%)	:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4678) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42816 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6634-t4678-kvm-centos7.zip Smoke tests completed. 100 look OK, 1 have errors Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	3653.54	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.05	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	74.81	test_kubernetes_clusters.py

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6634 (SL-JID-2158)

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

[sonarqubecloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[blueorangutan]

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3999

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4709) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37452 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6634-t4709-kvm-centos7.zip Smoke tests completed. 101 look OK, 0 have errors Only failed tests results shown below:

Test	Result	Time (s)	Test File