cloudstack
cloudstack copied to clipboard
Fixes #6621 - Update host memory stats
Description
This PR ensures that when getMemStat()
is called in KVM environments, the hosts actual used memory is returned, and not a static value that was retrieved when the cloudstack-agent was started.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
Feature/Enhancement Scale
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Screenshots (if appropriate):
How Has This Been Tested?
We have applied this patch into our own environment, built the packages and installed them on the managers and hosts. We then migrated VMs between hosts and saw the host memory usage being updated, instead of remaining static until the cloudstack-agent was restarted.
Found UI changes, kicking a new UI QA build @blueorangutan ui
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6622 (SL-JID-2118)
@Rubueno can you change the base branch of this PR to 4.17 and rebase your PR branch on 4.17?
Found UI changes, kicking a new UI QA build @blueorangutan ui
component:networking
was added by mistake
Found UI changes, kicking a new UI QA build @blueorangutan ui
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
Found UI changes, kicking a new UI QA build @blueorangutan ui
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
@Rubueno can you change the base branch of this PR to 4.17 and rebase your PR branch on 4.17?
Done as requested. Please let me know if there's something missing or done incorrect.
UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6622 (SL-JID-2119)
UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6622 (SL-JID-2120)
Codecov Report
Merging #6622 (f12cdc6) into 4.17 (6842583) will decrease coverage by
0.00%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## 4.17 #6622 +/- ##
============================================
- Coverage 5.86% 5.86% -0.01%
Complexity 3918 3918
============================================
Files 2451 2451
Lines 242238 242239 +1
Branches 37902 37902
============================================
Hits 14207 14207
- Misses 226461 226462 +1
Partials 1570 1570
Impacted Files | Coverage Δ | |
---|---|---|
...ervisor/kvm/resource/LibvirtComputingResource.java | 16.00% <0.00%> (-0.01%) |
:arrow_down: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
@blueorangutan package
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3954
Rebased onto a missing commit. Please restart required workflows.
@blueorangutan package
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3957
@blueorangutan test
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
Trillian test result (tid-4670) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39656 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6622-t4670-kvm-centos7.zip Smoke tests completed. 100 look OK, 1 have errors Only failed tests results shown below:
Test | Result | Time (s) | Test File |
---|---|---|---|
test_08_upgrade_kubernetes_ha_cluster | Failure |
572.22 | test_kubernetes_clusters.py |