cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Enable Flake8 rule W391

Open jbampton opened this issue 3 years ago • 3 comments

Best practice is to have one blank line at the end of Python files.

Remove unneeded blank lines from the end of files

Description

This PR standardizes the Python code.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [X] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [X] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [X] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

jbampton avatar Aug 03 '22 03:08 jbampton

CLGTM and job one in travis succeeds. this should be the only test we need is it @jbampton ?

DaanHoogland avatar Aug 03 '22 13:08 DaanHoogland

Hey @DaanHoogland seems Flake8 is being run by the Super-Linter and that check passed.

Can you please show me where Travis runs flake8 ?

jbampton avatar Aug 03 '22 14:08 jbampton

Hey @DaanHoogland seems Flake8 is being run by the Super-Linter and that check passed.

Can you please show me where Travis runs flake8 ?

If it does at all, it will be in the first job, https://app.travis-ci.com/github/apache/cloudstack/jobs/578591259 it was a genuine question and I guess you answered it ;)

DaanHoogland avatar Aug 03 '22 15:08 DaanHoogland

@blueorangutan package

DaanHoogland avatar Nov 10 '22 13:11 DaanHoogland

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Nov 10 '22 13:11 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. LL-JID 247

blueorangutan avatar Nov 10 '22 14:11 blueorangutan