cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

JDK Disabled Algorithms update

Open fermosan opened this issue 2 years ago • 18 comments

Description

An update for JdK disabled aglorithms to improve the security posture of the Cloudstack Management Portal. The selection of the disabled algorithms is the current "standard" and it will break clients that are not supported anymore.

  • Internet Explorer 11
  • Safari 6
  • Safari 7
  • Safari 8

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ X] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [X ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [X ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Our production environment (KVM, UBUNTU 20.04) runs on these changes for sometime now.

fermosan avatar Aug 01 '22 02:08 fermosan

@blueorangutan package

rohityadavcloud avatar Aug 05 '22 11:08 rohityadavcloud

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 05 '22 11:08 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3919

blueorangutan avatar Aug 05 '22 12:08 blueorangutan

@blueorangutan test matrix

rohityadavcloud avatar Aug 05 '22 18:08 rohityadavcloud

@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan avatar Aug 05 '22 18:08 blueorangutan

Trillian Build Failed (tid-4629)

blueorangutan avatar Aug 05 '22 18:08 blueorangutan

Trillian test result (tid-4628) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38695 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6594-t4628-xenserver-71.zip Smoke tests completed. 100 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 629.19 test_kubernetes_clusters.py

blueorangutan avatar Aug 06 '22 05:08 blueorangutan

Trillian test result (tid-4630) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41882 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6594-t4630-vmware-65u2.zip Smoke tests completed. 101 look OK, 0 have errors Only failed tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Aug 06 '22 06:08 blueorangutan

@blueorangutan test

rohityadavcloud avatar Aug 17 '22 08:08 rohityadavcloud

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Aug 17 '22 08:08 blueorangutan

Trillian test result (tid-4716) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40824 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6594-t4716-kvm-centos7.zip Smoke tests completed. 100 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_02_upgrade_kubernetes_cluster Failure 513.35 test_kubernetes_clusters.py

blueorangutan avatar Aug 17 '22 20:08 blueorangutan

Codecov Report

Merging #6594 (aa21b6f) into main (bbc1260) will increase coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #6594   +/-   ##
=========================================
  Coverage     10.42%   10.42%           
- Complexity     6701     6703    +2     
=========================================
  Files          2458     2458           
  Lines        243246   243246           
  Branches      38067    38067           
=========================================
+ Hits          25358    25362    +4     
+ Misses       214714   214709    -5     
- Partials       3174     3175    +1     
Impacted Files Coverage Δ
...dstack/network/contrail/model/ModelObjectBase.java 28.84% <0.00%> (+7.69%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 20 '22 13:09 codecov[bot]

@blueorangutan package

DaanHoogland avatar Sep 20 '22 14:09 DaanHoogland

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 20 '22 14:09 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4224

blueorangutan avatar Sep 20 '22 14:09 blueorangutan

@blueorangutan test

DaanHoogland avatar Sep 20 '22 17:09 DaanHoogland

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Sep 20 '22 17:09 blueorangutan

Trillian test result (tid-4938) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42631 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6594-t4938-kvm-centos7.zip Smoke tests completed. 102 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 628.68 test_kubernetes_clusters.py

blueorangutan avatar Sep 21 '22 05:09 blueorangutan

@fermosan I think making these default could cause cocerns for some users, could you instead propose this as a documentation PR to https://github.com/apache/cloudstack-documentation

rohityadavcloud avatar Apr 19 '23 07:04 rohityadavcloud

Closing on above remark - let's better describe this in our project docs. Thanks for the PR.

rohityadavcloud avatar Apr 19 '23 07:04 rohityadavcloud