cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

[WIP] New API: createConsoleURL

Open nvazquez opened this issue 3 years ago • 4 comments

Description

IN PROGRESS This PR creates a new API to create VM console URL allowing it to connect using other UI implementations

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

nvazquez avatar Jul 27 '22 14:07 nvazquez

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 01 '22 17:08 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 01 '22 17:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6577 (SL-JID-2044)

blueorangutan avatar Aug 01 '22 17:08 blueorangutan

@blueorangutan package

nvazquez avatar Aug 15 '22 03:08 nvazquez

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 15 '22 03:08 acs-robot

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 15 '22 03:08 blueorangutan

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3979

blueorangutan avatar Aug 15 '22 03:08 blueorangutan

@blueorangutan package

nvazquez avatar Aug 15 '22 03:08 nvazquez

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 15 '22 03:08 acs-robot

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 15 '22 03:08 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3981

blueorangutan avatar Aug 15 '22 04:08 blueorangutan

@blueorangutan test

nvazquez avatar Aug 15 '22 04:08 nvazquez

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Aug 15 '22 04:08 blueorangutan

Codecov Report

Merging #6577 (42e4497) into main (152a274) will increase coverage by 4.54%. The diff coverage is 4.49%.

@@             Coverage Diff              @@
##               main    #6577      +/-   ##
============================================
+ Coverage      5.87%   10.41%   +4.54%     
- Complexity     3933     6690    +2757     
============================================
  Files          2454     2455       +1     
  Lines        242633   243131     +498     
  Branches      37970    38062      +92     
============================================
+ Hits          14246    25316   +11070     
+ Misses       226811   214649   -12162     
- Partials       1576     3166    +1590     
Impacted Files Coverage Δ
.../main/java/com/cloud/capacity/CapacityManager.java 100.00% <ø> (+100.00%) :arrow_up:
...ud/consoleproxy/AgentBasedConsoleProxyManager.java 0.00% <0.00%> (ø)
...ain/java/com/cloud/consoleproxy/AgentHookBase.java 0.00% <0.00%> (ø)
...va/com/cloud/consoleproxy/ConsoleProxyManager.java 0.00% <0.00%> (ø)
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java 6.88% <0.00%> (+6.88%) :arrow_up:
...in/java/com/cloud/server/ManagementServerImpl.java 2.47% <0.00%> (+2.47%) :arrow_up:
...ava/com/cloud/servlet/ConsoleProxyClientParam.java 0.00% <0.00%> (ø)
...in/java/com/cloud/servlet/ConsoleProxyServlet.java 5.29% <0.00%> (+5.29%) :arrow_up:
...udstack/consoleproxy/ConsoleAccessManagerImpl.java 5.09% <5.09%> (ø)
server/src/main/java/com/cloud/api/ApiServlet.java 39.28% <28.57%> (+39.28%) :arrow_up:
... and 487 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 15 '22 06:08 codecov[bot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 15 '22 12:08 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 15 '22 12:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6577 (SL-JID-2145)

blueorangutan avatar Aug 15 '22 12:08 blueorangutan

@nvazquez can you rebase your branch against upstream main branch?

rohityadavcloud avatar Aug 15 '22 13:08 rohityadavcloud

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 15 '22 13:08 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 15 '22 13:08 blueorangutan

@rohityadavcloud done @DaanHoogland can you please review? @blueorangutan package

nvazquez avatar Aug 15 '22 13:08 nvazquez

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 15 '22 13:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6577 (SL-JID-2146)

blueorangutan avatar Aug 15 '22 13:08 blueorangutan

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 15 '22 13:08 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 15 '22 13:08 blueorangutan

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Aug 15 '22 13:08 acs-robot

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6577 (SL-JID-2147)

blueorangutan avatar Aug 15 '22 13:08 blueorangutan

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Aug 15 '22 13:08 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6577 (SL-JID-2148)

blueorangutan avatar Aug 15 '22 13:08 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3987

blueorangutan avatar Aug 15 '22 14:08 blueorangutan