Emc networker b&r

[fermosan]

Description

This PR...

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [X ] New feature (non-breaking change which adds functionality)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [ ] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

A small scale lab environment with two Hypervisors, One Management server, one zone, one cluster. Three different accounts with VMs. Multiple users performing common scenarios for seven days now. All the B&R cases with the exception of SLA Based backups that is not supported by the Backup Vendor have been tested. Backup and Restore of whole VMs and single volumes. Import of backup offerings from the external provider. Assignment of backup offerings to VMs. There is a basic implementation of the B&R functionality on the KVM Hypervisor Guru.

[harikrishna-patnala]

Great to see this PR @fermosan. Thank you.

Can you please add some description which gives some details about the PR changes like the operations that are supported, how to configure and all?

[fermosan]

Hello @harikrishna-patnala . There is a pending documentation pull as well at: https://github.com/apache/cloudstack-documentation/pull/281

As mentioned there all the B&R framework functionality is supported with the exception of SLA backups. Networker cannot support something like that without DELL EMC doing some implementation on their own for KVM hypervisors. If the documentation is not sufficient let me know what you want me to describe and i will be more than happy to do it.

Thanks again,

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3754

[DaanHoogland]

nice work @fermosan

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-1952)

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[fermosan]

@DaanHoogland @rohityadavcloud @harikrishna-patnala Is JaCoCo failing for some particular reason ?

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-1957)

[DaanHoogland]

@DaanHoogland @rohityadavcloud @harikrishna-patnala Is JaCoCo failing for some particular reason ?

are you fully ready yet, @fermosan ? let's not worry about jococo untill we are ready to merge.

[fermosan]

@DaanHoogland @rohityadavcloud @harikrishna-patnala Is JaCoCo failing for some particular reason ?

are you fully ready yet, @fermosan ? let's not worry about jococo untill we are ready to merge.

Our tests look good. We are running some scenarios now. Surely, there will be another commit for the documentation pull in cloudstack-documentation.

I am currently looking at the following scenario. Maybe you can suggest something. The backups are meant to expire at predefined retention days configured by the administrator on the Networker side. This will happen automatically and Cloudstack B&R Framework will be unaware of this.
It looks like BackupSyncTask in B&R implementation can be utilized to do that.

[fermosan]

@DaanHoogland @rohityadavcloud @harikrishna-patnala Is JaCoCo failing for some particular reason ?

are you fully ready yet, @fermosan ? let's not worry about jococo untill we are ready to merge.

Our tests look good. We are running some scenarios now. Surely, there will be another commit for the documentation pull in cloudstack-documentation.

I am currently looking at the following scenario. Maybe you can suggest something. The backups are meant to expire at predefined retention days configured by the administrator on the Networker side. This will happen automatically and Cloudstack B&R Framework will be unaware of this. It looks like BackupSyncTask in B&R implementation can be utilized to do that.

Yes. That worked like a charm. Will soon commit and we will do some internal testing as well.

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6550 (SL-JID-1961)

[fermosan]

@DaanHoogland This commit concludes all the designed functionality for the plugin. Backups are registered / removed properly from/to Cloudstack. We will keep testing in internally for a few more days and there are some plans for doing some more cleanups in the bash shell scripts in case the backup is not successful (with EMC Networker to blaim for this and not Cloudstack). There are few instructions to add in the documentation pull for administrators. However, Networker is quite complex piece of software and is impossible to go in great depth.

Also, in Dev mailing list a UI bug was found for creating Schedules. Is there a bug report / issue for that one or we need to open one ? I think @svenvogel acknowledged the bug.

Lastly, you think we can include this in the next release provided that everything is working as expected?

[DaanHoogland]

@rohityadavcloud , what is the status of the jacoco validator? I've seen unexplained failures in other PRs too.

[DaanHoogland]

@DaanHoogland This commit concludes all the designed functionality for the plugin. Backups are registered / removed properly from/to Cloudstack. We will keep testing in internally for a few more days and there are some plans for doing some more cleanups in the bash shell scripts in case the backup is not successful (with EMC Networker to blaim for this and not Cloudstack). There are few instructions to add in the documentation pull for administrators. However, Networker is quite complex piece of software and is impossible to go in great depth.

:+1:

...

Lastly, you think we can include this in the next release provided that everything is working as expected?

sure, if it works it's in

[DaanHoogland]

you have a small conflict @fermosan . can you resolve it? (will happen more often the coming time, I'm sure)

[github-actions[bot]]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: :heavy_multiplication_x: (SL-JID-1964)

[acs-robot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.