cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Refactor test and change IP range

Open Pearl1594 opened this issue 2 years ago • 21 comments

Description

This PR moves the test_data from the specific test to the central location - test_data.py and also changes the network cidr from 10.1.0.0/16 to 10.2.0.0/16 as it conflicts with the IP range of the lab where trillian jobs runs - thus leading to failures, which could be confusing

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [X] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

est Site 2 Site VPN Across redundant VPCs ... === TestName: test_01_redundant_vpc_site2site_vpn | Status : SUCCESS ===
ok
Test Site 2 Site VPN Across VPCs ... === TestName: test_01_vpc_site2site_vpn_multiple_options | Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_01_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test Site 2 Site VPN Across VPCs ... === TestName: test_01_vpc_site2site_vpn | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 4 tests in 1812.057s

OK

Pearl1594 avatar Jun 28 '22 10:06 Pearl1594

@blueorangutan package

Pearl1594 avatar Jun 28 '22 11:06 Pearl1594

@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 28 '22 11:06 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3664

blueorangutan avatar Jun 28 '22 12:06 blueorangutan

@blueorangutan test

nvazquez avatar Jun 30 '22 00:06 nvazquez

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Jun 30 '22 00:06 blueorangutan

Trillian Build Failed (tid-4406)

blueorangutan avatar Jun 30 '22 00:06 blueorangutan

@blueorangutan test

rohityadavcloud avatar Jun 30 '22 13:06 rohityadavcloud

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Jun 30 '22 13:06 blueorangutan

Trillian test result (tid-4413) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28659 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6512-t4413-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestRVPCSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py

blueorangutan avatar Jun 30 '22 22:06 blueorangutan

@blueorangutan test

rohityadavcloud avatar Jul 06 '22 07:07 rohityadavcloud

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Jul 06 '22 07:07 blueorangutan

Trillian test result (tid-4437) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30744 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6512-t4437-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestRVPCSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py

blueorangutan avatar Jul 06 '22 16:07 blueorangutan

@Pearl1594 this needs fixing, smoketests are failing

@blueorangutan test

rohityadavcloud avatar Jul 09 '22 16:07 rohityadavcloud

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Jul 09 '22 16:07 blueorangutan

Trillian test result (tid-4474) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29507 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6512-t4474-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestRVPCSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py

blueorangutan avatar Jul 10 '22 01:07 blueorangutan

@blueorangutan test

rohityadavcloud avatar Jul 16 '22 16:07 rohityadavcloud

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Jul 16 '22 16:07 blueorangutan

Trillian test result (tid-4513) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29997 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6512-t4513-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestRVPCSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py

blueorangutan avatar Jul 17 '22 00:07 blueorangutan

@Pearl1594 can you please check the failures

shwstppr avatar Jul 25 '22 07:07 shwstppr

Sorry for the delay @shwstppr. Will check the failures, however, it isn't a necessary fix for 4.17.1. Thanks.

Pearl1594 avatar Aug 09 '22 06:08 Pearl1594

@Pearl1594 thanks for the update. Moving to the next milestone for now.

shwstppr avatar Aug 09 '22 06:08 shwstppr

@blueorangutan package

rohityadavcloud avatar Oct 08 '22 06:10 rohityadavcloud

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 08 '22 06:10 blueorangutan

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4387

blueorangutan avatar Oct 08 '22 10:10 blueorangutan

@blueorangutan package

DaanHoogland avatar Oct 11 '22 11:10 DaanHoogland

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Oct 11 '22 11:10 blueorangutan

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4423

blueorangutan avatar Oct 11 '22 13:10 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4428

blueorangutan avatar Oct 11 '22 15:10 blueorangutan

@blueorangutan test

DaanHoogland avatar Oct 12 '22 08:10 DaanHoogland

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Oct 12 '22 08:10 blueorangutan