cloudstack
cloudstack copied to clipboard
apache
Externalizes logrotate service frequency timer in VR
Description
Currently, the frequency of execution of the logrotate service, in virtual routers, is defined to be executed every hour, and it is not possible to change this value via ACS.
This behavior has been fixed so that the operator is now able to define this interval using the global configuration router.logrotate.frequency, which follows the pattern adopted by the onCalendar field of the Systemd Timers tool. Such a pattern uses the format: [* *-*-* *:*:*] which means [<DAY_OF_WEEK> <YEAR>-<MONTH>-<DAY> <HOUR>:<MINUTE>:<SECOND>]. However, the ACS uses only the last block of this format, that is, [<HOUR>:<MINUTE>:<SECOND>], since the use cases presented show that times greater than 24 hours lead to problems in the VRs resulting from discharge disk space usage.
The default value for this setting was kept, being represented by: *:00:00 (hourly). The table below represents some of the possible values and their meanings:
| Valor | Significado |
|---|---|
| *:*:00 | Every minute |
| *:*/15:00 | Every 15 minutes |
| *:00:00 | Every hour |
| */2:00:00 | Every 2 hours |
| 00:00:00 | Every day at exactly 00:00:00 |
Note: the minimum file size is fixed at 10M, which means that the logrotate service will run, but it will not rotate the log files if it does not reach the minimum size.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
How Has This Been Tested?
Changing the value of router.logrotate.frequency and checking if this value has been applied in the VR.
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3660
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6507 (SL-JID-1867)
Trillian test result (tid-4387) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39666 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6507-t4387-kvm-centos7.zip Smoke tests completed. 98 look OK, 0 have errors Only failed tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
0.0% Coverage
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sureshanaparti a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 3671
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3691
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
Trillian test result (tid-4473) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37253 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6507-t4473-kvm-centos7.zip Smoke tests completed. 98 look OK, 0 have errors Only failed tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3864
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3867
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
Trillian test result (tid-4585) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41507 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6507-t4585-vmware-67u3.zip Smoke tests completed. 99 look OK, 1 have errors Only failed tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_08_upgrade_kubernetes_ha_cluster | Failure |
645.31 | test_kubernetes_clusters.py |