cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

VPC VR: fix /etc/network/interfaces is misconfigured

Open weizhouapache opened this issue 2 years ago • 23 comments

Description

This PR fixes that the /etc/network/interfaces is misconfigured in VPC VR startup, which causes VPC VR to be stuck for 1 minute and continue working.

The issue is because ifup eth0 and ifdown eth0 do not work when /etc/network/interfaces is not correct in VPC VR.

severity: to be discussed. This requires a new systemvm template.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache avatar Jun 02 '22 20:06 weizhouapache

@blueorangutan package

weizhouapache avatar Jun 02 '22 22:06 weizhouapache

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 02 '22 22:06 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3521

blueorangutan avatar Jun 02 '22 22:06 blueorangutan

Trillian Build Failed (tid-4283)

blueorangutan avatar Jun 03 '22 06:06 blueorangutan

Trillian Build Failed (tid-4285)

blueorangutan avatar Jun 03 '22 07:06 blueorangutan

Trillian Build Failed (tid-4286)

blueorangutan avatar Jun 03 '22 07:06 blueorangutan

Trillian Build Failed (tid-4288)

blueorangutan avatar Jun 03 '22 07:06 blueorangutan

Trillian Build Failed (tid-4289)

blueorangutan avatar Jun 03 '22 07:06 blueorangutan

Trillian Build Failed (tid-4290)

blueorangutan avatar Jun 03 '22 08:06 blueorangutan

Trillian Build Failed (tid-4291)

blueorangutan avatar Jun 03 '22 08:06 blueorangutan

Trillian Build Failed (tid-4292)

blueorangutan avatar Jun 03 '22 08:06 blueorangutan

Trillian Build Failed (tid-4293)

blueorangutan avatar Jun 03 '22 09:06 blueorangutan

Trillian test result (tid-4296) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50014 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6435-t4296-kvm-centos7.zip Smoke tests completed. 95 look OK, 2 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_01_invalid_upgrade_kubernetes_cluster Failure 3610.74 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 3611.80 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 81.90 test_kubernetes_clusters.py
ContextSuite context=TestSharedNetwork>:setup Error 45.32 test_network.py

blueorangutan avatar Jun 03 '22 23:06 blueorangutan

Trillian test result (tid-4300) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53311 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6435-t4300-kvm-centos7.zip Smoke tests completed. 94 look OK, 3 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_08_arping_in_ssvm Failure 5.15 test_diagnostics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Failure 337.49 test_vpc_redundant.py
test_01_invalid_upgrade_kubernetes_cluster Failure 3601.43 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 3606.31 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.05 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.04 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 85.68 test_kubernetes_clusters.py

blueorangutan avatar Jun 04 '22 21:06 blueorangutan

Trillian test result (tid-4301) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49075 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6435-t4301-kvm-centos7.zip Smoke tests completed. 95 look OK, 2 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Failure 341.68 test_vpc_redundant.py
test_01_invalid_upgrade_kubernetes_cluster Failure 3614.53 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 3612.07 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.04 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.03 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.03 test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown Error 79.94 test_kubernetes_clusters.py

blueorangutan avatar Jun 05 '22 19:06 blueorangutan

@blueorangutan package

weizhouapache avatar Jun 08 '22 14:06 weizhouapache

Trillian test result (tid-4313) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 35606 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6435-t4313-kvm-ubuntu22.zip Smoke tests completed. 97 look OK, 0 have errors Only failed tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Jun 09 '22 02:06 blueorangutan

@blueorangutan package

weizhouapache avatar Jun 09 '22 09:06 weizhouapache

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan avatar Jun 09 '22 09:06 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3551

blueorangutan avatar Jun 09 '22 09:06 blueorangutan

Trillian test result (tid-4315) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 35494 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6435-t4315-kvm-ubuntu22.zip Smoke tests completed. 97 look OK, 0 have errors Only failed tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Jun 09 '22 20:06 blueorangutan

ping @weizhouapache any update on this?

rohityadavcloud avatar Jul 20 '22 10:07 rohityadavcloud

ping @weizhouapache any update on this?

@rohityadavcloud I did not work on this recently. based on our previous dicsussion, it looks better to create another PR to configure only control IP in init.sh (the change in this PR can be added to the new PR as well).

weizhouapache avatar Jul 20 '22 11:07 weizhouapache

Based on discussion with @weizhouapache moving this to the next milestone

shwstppr avatar Aug 18 '22 12:08 shwstppr

@weizhouapache @shwstppr does this require a new systemvmtemplate or are the changes patches and run after the patching process? @blueorangutan package

rohityadavcloud avatar Dec 09 '22 10:12 rohityadavcloud

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 09 '22 10:12 blueorangutan

@weizhouapache @shwstppr does this require a new systemvmtemplate or are the changes patches and run after the patching process? @blueorangutan package

@rohityadavcloud yes, it requires a new systemvm template

Actually, any change with init.sh and bootstrap.sh requires a new systemvm template

weizhouapache avatar Dec 09 '22 11:12 weizhouapache

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with

@rohityadavcloud yes, it requires a new systemvm template

Actually, any change with init.sh and bootstrap.sh requires a new systemvm template SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan avatar Dec 09 '22 11:12 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4828

blueorangutan avatar Dec 09 '22 12:12 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4829

blueorangutan avatar Dec 09 '22 12:12 blueorangutan