cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Published 20 hours ago • verified publisher icon apache

Validate host tags on VM live scale

Open BryanMLima opened this issue 3 years ago • 7 comments

Description

Currently, ACS does not validate host tags on running VMs that have their computing resources increased via Scale VM command. Therefore, if a service offering with host tags deploys on a host with the same host tags, it is permitted to live scale this VM to another service offering with another host tags. This PR aims to fix this bug, verifying the host tags on a VM live scaling.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [x] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

This was tested in a local lab with the following scenario:

  1. VM deployed with a service offering with host tags hdd.
  2. Tried to live scale the VM with another service offering with host tags ssd.
  3. An error occurred while scaling the VM, as expected.

BryanMLima avatar May 23 '22 21:05 BryanMLima

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar May 23 '22 22:05 sonarqubecloud[bot]

@blueorangutan package

GutoVeronezi avatar Jun 21 '22 16:06 GutoVeronezi

@GutoVeronezi a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 21 '22 16:06 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 3618

blueorangutan avatar Jun 21 '22 18:06 blueorangutan

@blueorangutan test

sureshanaparti avatar Jun 22 '22 04:06 sureshanaparti

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Jun 22 '22 04:06 blueorangutan

Trillian test result (tid-4351) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36722 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6409-t4351-kvm-centos7.zip Smoke tests completed. 98 look OK, 0 have errors Only failed tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Jun 22 '22 14:06 blueorangutan

@DaanHoogland @GutoVeronezi Could you take another look on this one? I think this PR is already good to merge.

BryanMLima avatar Aug 30 '22 15:08 BryanMLima

trusting the developers tests on this one

DaanHoogland avatar Aug 31 '22 07:08 DaanHoogland

cc @DaanHoogland milestone missing

rohityadavcloud avatar Aug 31 '22 19:08 rohityadavcloud

Also manual tests if any required missing cc @shwstppr @harikrishna-patnala

rohityadavcloud avatar Aug 31 '22 19:08 rohityadavcloud