cloudstack
cloudstack copied to clipboard
Improve log messages on VolumeOrchestrator class
Description
This PR aims to improve several log entries in the VolumeOrchestrator class by adding more clear and precise information to facilitate future troubleshooting.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
How Has This Been Tested?
The changes were tested by checking the log entries during volume manipulation (creating, deleting, migrating volumes between different storages, creating volumes from snapshots, etc.).
I like the premise, but some of the implementation details worry me.
btw, I reviewed the sonarcloud bugs reported. I think we can ignore these for now as these are not really new ones. As for the code smells, please have a look. Some of those can certainly be addressed;
SonarCloud Quality Gate failed.
@DaanHoogland About the code smells, most of them were not related to the changes made in this PR, but I addressed the ones that were and could be improved.
Found UI changes, kicking a new UI QA build @blueorangutan ui
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6408 (SL-JID-1673)
Found UI changes, kicking a new UI QA build @blueorangutan ui
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6408 (SL-JID-1714)
Codecov Report
:exclamation: No coverage uploaded for pull request base (
main@96594ae
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #6408 +/- ##
=======================================
Coverage ? 5.87%
Complexity ? 3933
=======================================
Files ? 2454
Lines ? 242614
Branches ? 37965
=======================================
Hits ? 14246
Misses ? 226791
Partials ? 1577
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more