cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Improve log messages on VolumeOrchestrator class

Open paulazomig opened this issue 2 years ago • 10 comments

Description

This PR aims to improve several log entries in the VolumeOrchestrator class by adding more clear and precise information to facilitate future troubleshooting.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

How Has This Been Tested?

The changes were tested by checking the log entries during volume manipulation (creating, deleting, migrating volumes between different storages, creating volumes from snapshots, etc.).

paulazomig avatar May 23 '22 13:05 paulazomig

I like the premise, but some of the implementation details worry me.

btw, I reviewed the sonarcloud bugs reported. I think we can ignore these for now as these are not really new ones. As for the code smells, please have a look. Some of those can certainly be addressed;

SonarCloud Quality Gate failed. Quality Gate failed

Bug C 6 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 10 Code Smells

0.0% 0.0% Coverage 0.0% 0.0% Duplication

DaanHoogland avatar May 23 '22 14:05 DaanHoogland

@DaanHoogland About the code smells, most of them were not related to the changes made in this PR, but I addressed the ones that were and could be improved.

paulazomig avatar May 27 '22 17:05 paulazomig

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Jun 03 '22 19:06 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Jun 03 '22 19:06 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6408 (SL-JID-1673)

blueorangutan avatar Jun 03 '22 19:06 blueorangutan

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Jun 10 '22 19:06 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Jun 10 '22 19:06 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6408 (SL-JID-1714)

blueorangutan avatar Jun 10 '22 19:06 blueorangutan

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@96594ae). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6408   +/-   ##
=======================================
  Coverage        ?    5.87%           
  Complexity      ?     3933           
=======================================
  Files           ?     2454           
  Lines           ?   242614           
  Branches        ?    37965           
=======================================
  Hits            ?    14246           
  Misses          ?   226791           
  Partials        ?     1577           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 10 '22 20:08 codecov-commenter