cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Published 20 hours ago • verified publisher icon apache

api, vmware: Allow VM setting/detail for disk controller (root/data) to override template details

Open Pearl1594 opened this issue 2 years ago • 54 comments

Description

This PR allows VM details wrt root & data disk controller passed via details parameter of deployVMCmd to take precedence over template settings, i.e., the order of precedence for determining VM disk controller is : VM details passed during deployment > template settings > global setting vmware.root.disk.controller .

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Pearl1594 avatar Apr 18 '22 07:04 Pearl1594

@blueorangutan package

Pearl1594 avatar Apr 18 '22 07:04 Pearl1594

@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 18 '22 07:04 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3195

blueorangutan avatar Apr 18 '22 08:04 blueorangutan

@blueorangutan test matrix

Pearl1594 avatar Apr 18 '22 09:04 Pearl1594

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan avatar Apr 18 '22 09:04 blueorangutan

Trillian test result (tid-3926) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30821 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t3926-kvm-centos7.zip Smoke tests completed. 93 look OK, 0 have errors Only failed tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Apr 18 '22 18:04 blueorangutan

Trillian test result (tid-3927) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33915 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t3927-vmware-65u2.zip Smoke tests completed. 92 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_deploy_vm_from_iso Error 7.77 test_deploy_vm_iso.py

blueorangutan avatar Apr 18 '22 18:04 blueorangutan

Trillian test result (tid-3925) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34828 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t3925-xenserver-71.zip Smoke tests completed. 91 look OK, 2 have errors Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestListIdsParams>:teardown Error 1.15 test_list_ids_parameter.py
test_02_cancel_host_maintenace_with_migration_jobs Error 1990.88 test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs Error 1990.94 test_host_maintenance.py

blueorangutan avatar Apr 18 '22 19:04 blueorangutan

@Pearl1594 is this ready for review?

nvazquez avatar Apr 20 '22 02:04 nvazquez

@blueorangutan package

Pearl1594 avatar Apr 22 '22 05:04 Pearl1594

@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan avatar Apr 22 '22 05:04 blueorangutan

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 3269

blueorangutan avatar Apr 22 '22 06:04 blueorangutan

@blueorangutan package

Pearl1594 avatar Apr 22 '22 06:04 Pearl1594

@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 22 '22 06:04 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3271

blueorangutan avatar Apr 22 '22 07:04 blueorangutan

Is this essential for 4.17 @nvazquez @Pearl1594 ?

rohityadavcloud avatar Apr 26 '22 06:04 rohityadavcloud

@rohityadavcloud this isn't essential for 4.17.0 as this has always been the behavior and there also exists a workaround, where users can change the template setting for root disk controller. So IMO this can go into 4.17.1

Pearl1594 avatar Apr 26 '22 07:04 Pearl1594

@blueorangutan package

rohityadavcloud avatar Jun 30 '22 06:06 rohityadavcloud

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 30 '22 06:06 blueorangutan

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3682

blueorangutan avatar Jun 30 '22 11:06 blueorangutan

@blueorangutan package

rohityadavcloud avatar Jul 07 '22 09:07 rohityadavcloud

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan avatar Jul 07 '22 09:07 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3725

blueorangutan avatar Jul 07 '22 09:07 blueorangutan

@blueorangutan test matrix

rohityadavcloud avatar Jul 07 '22 09:07 rohityadavcloud

@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan avatar Jul 07 '22 10:07 blueorangutan

Trillian test result (tid-4444) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41636 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4444-xenserver-71.zip Smoke tests completed. 97 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 1037.06 test_kubernetes_clusters.py

blueorangutan avatar Jul 07 '22 21:07 blueorangutan

Trillian test result (tid-4445) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42395 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4445-kvm-centos7.zip Smoke tests completed. 97 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 805.25 test_kubernetes_clusters.py

blueorangutan avatar Jul 07 '22 22:07 blueorangutan

Trillian test result (tid-4446) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50385 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6276-t4446-vmware-65u2.zip Smoke tests completed. 97 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_deploy_vm_from_iso Error 8.00 test_deploy_vm_iso.py

blueorangutan avatar Jul 08 '22 00:07 blueorangutan

@Pearl1594 will you apply @GutoVeronezi's suggestion?

DaanHoogland avatar Jul 08 '22 09:07 DaanHoogland

@Pearl1594 This also needs base branch change to 4.17, I see this is targetted to 4.17.1

harikrishna-patnala avatar Jul 20 '22 07:07 harikrishna-patnala