cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Published 20 hours ago • verified publisher icon apache

[Draft] UserData as first class resource

Open harikrishna-patnala opened this issue 2 years ago • 171 comments

Description

This PR introduces a new feature to make userdata as a first class resource much like existing SSH keys. Please check the detailed feature specification document here at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Userdata+as+a+first+class+resource

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [x] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [x] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

image

harikrishna-patnala avatar Apr 05 '22 04:04 harikrishna-patnala

@blueorangutan package

harikrishna-patnala avatar Apr 05 '22 04:04 harikrishna-patnala

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 05 '22 04:04 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3074

blueorangutan avatar Apr 05 '22 04:04 blueorangutan

@blueorangutan package

harikrishna-patnala avatar Apr 07 '22 06:04 harikrishna-patnala

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 07 '22 06:04 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3092

blueorangutan avatar Apr 07 '22 07:04 blueorangutan

Hi @ravening, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?

github-actions[bot] avatar Apr 11 '22 14:04 github-actions[bot]

Hi @ravening, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?

you are drunk. get some sleep :P this is not my pr :D

ravening avatar Apr 11 '22 14:04 ravening

Hi @ravening, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?

@harikrishna-patnala ^^

DaanHoogland avatar Apr 12 '22 09:04 DaanHoogland

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Apr 18 '22 12:04 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Apr 18 '22 12:04 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1392)

blueorangutan avatar Apr 18 '22 12:04 blueorangutan

PR Coverage Report

CLASS INSTRUCTION MISSED INSTRUCTION COVERED BRANCH MISSED BRANCH COVERED LINE MISSED LINE COVERED
VirtualMachineManagerImpl 15612 0 1498 0 3072 0
VMTemplateVO 511 113 4 0 151 32
UserDataVO 54 0 0 0 22 0
UserDataDaoImpl 83 0 0 0 11 0
UserVmVO 136 0 2 0 43 0
TemplateObject 820 0 96 0 204 0
VMwareGuru 2768 52 222 0 512 5
KubernetesClusterResourceModifierActionWorker 1847 0 140 0 325 0
KubernetesClusterStartWorker 2686 0 168 0 426 0
ServiceVirtualMachine 19 0 0 0 2 0
ApiResponseHelper 11935 0 1242 0 2721 0
TemplateJoinDaoImpl 1506 0 140 0 304 0
TemplateJoinVO 243 0 0 0 83 0
NetworkModelImpl 5791 0 792 0 1240 0
AutoScaleManagerImpl 3303 0 320 0 691 0
CloudZonesNetworkElement 387 0 28 0 89 0
ConfigDriveNetworkElement 1470 0 173 0 306 0
CommandSetupHelper 3750 0 270 0 699 0
ManagementServerImpl 12261 0 1096 0 2456 0
TemplateManagerImpl 5073 0 700 0 1056 0
UserVmManagerImpl 21079 0 2616 0 3926 0

acs-robot avatar Apr 18 '22 12:04 acs-robot

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Apr 21 '22 04:04 acs-robot

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Apr 21 '22 20:04 github-actions[bot]

@harikrishna-patnala could you add some description to the PR?

GutoVeronezi avatar Apr 22 '22 19:04 GutoVeronezi

(@harikrishna-patnala I'm testing new sonarcloud/bot integration, merging your PR branch with main to see how coverage analysis behaves)

rohityadavcloud avatar May 03 '22 20:05 rohityadavcloud

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar May 07 '22 06:05 github-actions[bot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar May 10 '22 06:05 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar May 10 '22 06:05 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1539)

blueorangutan avatar May 10 '22 06:05 blueorangutan

@blueorangutan package

harikrishna-patnala avatar May 10 '22 07:05 harikrishna-patnala

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar May 10 '22 07:05 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3377

blueorangutan avatar May 10 '22 08:05 blueorangutan

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar May 18 '22 04:05 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar May 18 '22 04:05 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1583)

blueorangutan avatar May 18 '22 04:05 blueorangutan

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar May 18 '22 06:05 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar May 18 '22 06:05 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1584)

blueorangutan avatar May 18 '22 06:05 blueorangutan