cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Published 20 hours ago • verified publisher icon apache

Fix hv_ss_reserve value for volumes on migration

Open nvazquez opened this issue 2 years ago • 26 comments

Description

This PR updates the volume hv_ss_reserve value for managed storage on volume migration attempt, so it can correctly set the destination size value Fixes: #5915

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [x] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

nvazquez avatar Mar 09 '22 16:03 nvazquez

@blueorangutan package

nvazquez avatar Mar 09 '22 16:03 nvazquez

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan avatar Mar 09 '22 16:03 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2812

blueorangutan avatar Mar 09 '22 17:03 blueorangutan

@blueorangutan test

nvazquez avatar Mar 09 '22 17:03 nvazquez

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Mar 09 '22 17:03 blueorangutan

Trillian test result (tid-3544) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29290 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3544-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_iso.py

blueorangutan avatar Mar 10 '22 02:03 blueorangutan

@blueorangutan test

nvazquez avatar Mar 10 '22 02:03 nvazquez

@blueorangutan test

nvazquez avatar Mar 10 '22 11:03 nvazquez

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan avatar Mar 10 '22 11:03 blueorangutan

@blueorangutan test matrix

nvazquez avatar Mar 10 '22 14:03 nvazquez

@blueorangutan test matrix

nvazquez avatar Mar 10 '22 15:03 nvazquez

@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan avatar Mar 10 '22 15:03 blueorangutan

Trillian Build Failed (tid-3565)

blueorangutan avatar Mar 10 '22 16:03 blueorangutan

Trillian test result (tid-3558) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32325 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3558-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_02_list_snapshots_with_removed_data_store Error 42.40 test_snapshots.py

blueorangutan avatar Mar 10 '22 20:03 blueorangutan

@blueorangutan test matrix

nvazquez avatar Mar 11 '22 03:03 nvazquez

@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan avatar Mar 11 '22 03:03 blueorangutan

Trillian test result (tid-3572) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32478 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3572-kvm-centos7.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_02_list_snapshots_with_removed_data_store Error 43.27 test_snapshots.py

blueorangutan avatar Mar 11 '22 13:03 blueorangutan

Trillian test result (tid-3571) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33930 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3571-xenserver-71.zip Smoke tests completed. 91 look OK, 1 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_02_list_snapshots_with_removed_data_store Error 46.81 test_snapshots.py

blueorangutan avatar Mar 11 '22 13:03 blueorangutan

@blueorangutan test centos7 vmware-67u3

nvazquez avatar Mar 12 '22 04:03 nvazquez

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan avatar Mar 12 '22 04:03 blueorangutan

Trillian test result (tid-3586) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35307 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3586-vmware-67u3.zip Smoke tests completed. 90 look OK, 2 have errors Only failed tests results shown below:

Test Result Time (s) Test File
test_04_migrate_detached_volume Error 62.31 test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store Error 47.54 test_snapshots.py

blueorangutan avatar Mar 12 '22 14:03 blueorangutan

Trillian test result (tid-3573) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 132420 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3573-vmware-65u2.zip Smoke tests completed. 56 look OK, 35 have errors Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestRVPCSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
test_01_create_template Error 69.02 test_templates.py
test_CreateTemplateWithDuplicateName Error 142.58 test_templates.py
test_02_create_template_with_checksum_sha1 Error 65.41 test_templates.py
test_03_create_template_with_checksum_sha256 Error 65.41 test_templates.py
test_04_create_template_with_checksum_md5 Error 65.49 test_templates.py
test_05_create_template_with_no_checksum Error 65.43 test_templates.py
test_03_delete_template Error 1.06 test_templates.py
test_04_extract_template Error 1.06 test_templates.py
test_09_list_templates_download_details Failure 0.07 test_templates.py
ContextSuite context=TestRemoteDiagnostics>:setup Error 0.00 test_diagnostics.py
ContextSuite context=TestDeployVMFromISO>:setup Error 0.00 test_deploy_vm_iso.py
ContextSuite context=TestLoadBalance>:setup Error 0.00 test_loadbalance.py
ContextSuite context=TestVolumes>:setup Error 1955.93 test_volumes.py
test_3d_gpu_support Error 1513.91 test_deploy_vgpu_enabled_vm.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup Error 0.00 test_password_server.py
ContextSuite context=TestPrivateGwACL>:setup Error 0.00 test_privategw_acl.py
ContextSuite context=TestDeployVmWithUserData>:setup Error 0.00 test_deploy_vm_with_userdata.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup Error 0.00 test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestResetVmOnReboot>:setup Error 0.00 test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup Error 0.00 test_resource_accounting.py
ContextSuite context=TestPortForwardingRules>:setup Error 0.00 test_portforwardingrules.py
ContextSuite context=TestDomainsServiceOfferings>:setup Error 1515.30 test_domain_service_offerings.py
test_list_clusters_metrics Error 1511.95 test_metrics_api.py
test_list_vms_metrics Error 0.18 test_metrics_api.py
test_04_migrate_detached_volume Error 61.31 test_vm_life_cycle.py
ContextSuite context=TestVAppsVM>:setup Error 1557.43 test_vm_life_cycle.py
test_10_attachAndDetach_iso Failure 1510.73 test_vm_life_cycle.py
test_delete_account Error 1511.95 test_network.py
test_delete_network_while_vm_on_it Error 1.12 test_network.py
test_deploy_vm_l2network Error 1.12 test_network.py
test_l2network_restart Error 2.21 test_network.py
ContextSuite context=TestPortForwarding>:setup Error 3.38 test_network.py
ContextSuite context=TestPublicIP>:setup Error 3.49 test_network.py
test_reboot_router Failure 0.04 test_network.py
test_releaseIP Error 1.65 test_network.py
ContextSuite context=TestRouterRules>:setup Error 1.70 test_network.py
ContextSuite context=TestVPCRedundancy>:setup Error 0.00 test_vpc_redundant.py
ContextSuite context=TestNetworkACL>:setup Error 0.00 test_network_acl.py
ContextSuite context=TestRouterDHCPHosts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup Error 0.00 test_router_dns.py
test_01_invalid_upgrade_kubernetes_cluster Failure 0.01 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster Failure 0.01 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.00 test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster Failure 0.00 test_kubernetes_clusters.py
ContextSuite context=TestServiceOfferings>:setup Error 1511.94 test_service_offerings.py
ContextSuite context=TestRouterDnsService>:setup Error 0.00 test_router_dnsservice.py
ContextSuite context=TestAdapterTypeForNic>:setup Error 0.00 test_nic_adapter_type.py
ContextSuite context=TestRouterServices>:setup Error 0.00 test_routers.py
test_01_add_delete_kubernetes_supported_version Error 1802.14 test_kubernetes_supported_versions.py
ContextSuite context=TestIsolatedNetworks>:setup Error 0.00 test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup Error 0.00 test_routers_network_ops.py
ContextSuite context=TestSnapshotRootDisk>:setup Error 0.00 test_snapshots.py
ContextSuite context=TestInternalLb>:setup Error 0.00 test_internal_lb.py
test_01_create_iso_with_checksum_sha1 Error 66.42 test_iso.py
test_02_create_iso_with_checksum_sha256 Error 66.39 test_iso.py
test_03_create_iso_with_checksum_md5 Error 66.39 test_iso.py
test_04_create_iso_with_no_checksum Error 66.38 test_iso.py
test_01_create_iso Failure 1513.37 test_iso.py
ContextSuite context=TestISO>:setup Error 3025.74 test_iso.py
ContextSuite context=TestListIdsParams>:setup Error 0.00 test_list_ids_parameter.py
ContextSuite context=TestRouterIpTablesPolicies>:setup Error 0.00 test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup Error 0.00 test_routers_iptables_default_policy.py
ContextSuite context=TestVPCNics>:setup Error 0.00 test_vpc_router_nics.py

blueorangutan avatar Mar 12 '22 16:03 blueorangutan

@blueorangutan package

shwstppr avatar Jul 08 '22 06:07 shwstppr

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 08 '22 06:07 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3731

blueorangutan avatar Jul 08 '22 07:07 blueorangutan

@nvazquez is this ready review/testing or more changes needed?

shwstppr avatar Aug 12 '22 04:08 shwstppr

@shwstppr it is not ready, still needs some work, will try to find some time for it and will update this PR

nvazquez avatar Aug 12 '22 13:08 nvazquez

Based on discussion with @nvazquez moving this to next milestone

shwstppr avatar Aug 18 '22 11:08 shwstppr

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Sep 27 '22 07:09 github-actions[bot]

@nvazquez can you resolve the conflicts?

DaanHoogland avatar Dec 13 '22 09:12 DaanHoogland