cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

[WIP] UI: Integrate Tungsten Fabric

Open utchoang opened this issue 3 years ago • 13 comments

Description

This PR for adding new UI of Tungsten Fabric

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

image image

How Has This Been Tested?

utchoang avatar Oct 14 '21 09:10 utchoang

@utchoang what's the status of this PR ? Is it ready for review and testing ?

weizhouapache avatar Feb 11 '22 15:02 weizhouapache

@weizhouapache This PR is not ready for review as it is related to PR https://github.com/apache/cloudstack/pull/4205 which needs to be completed first.

utchoang avatar Feb 14 '22 00:02 utchoang

@utchoang (cc @weizhouapache @radu-stefanache ) does it make sense to merge these PRs? the TF PR contains reference to the phased out UI and needs this to be usefull to the layman.

DaanHoogland avatar Feb 14 '22 09:02 DaanHoogland

Hi @${author}, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?

github-actions[bot] avatar Apr 07 '22 05:04 github-actions[bot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Sep 15 '22 07:09 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Sep 15 '22 07:09 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5579 (SL-JID-2364)

blueorangutan avatar Sep 15 '22 07:09 blueorangutan

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Sep 16 '22 03:09 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Sep 16 '22 03:09 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5579 (SL-JID-2371)

blueorangutan avatar Sep 16 '22 03:09 blueorangutan

@blueorangutan package

DaanHoogland avatar Sep 21 '22 08:09 DaanHoogland

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 21 '22 08:09 blueorangutan

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4229

blueorangutan avatar Sep 21 '22 09:09 blueorangutan

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Oct 05 '22 21:10 github-actions[bot]

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Oct 07 '22 03:10 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Oct 07 '22 03:10 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5579 (SL-JID-2468)

blueorangutan avatar Oct 07 '22 03:10 blueorangutan

Found UI changes, kicking a new UI QA build @blueorangutan ui

acs-robot avatar Oct 07 '22 09:10 acs-robot

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Oct 07 '22 09:10 blueorangutan

UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5579 (SL-JID-2469)

blueorangutan avatar Oct 07 '22 09:10 blueorangutan

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Oct 07 '22 10:10 sonarqubecloud[bot]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Oct 28 '22 13:10 github-actions[bot]

@utchoang Can you rebase and fix the conflicts?

cc: @svenvogel

kiwiflyer avatar Nov 16 '22 09:11 kiwiflyer

@kiwiflyer @utchoang I've fixed the conflicts and had to create a new PR to push the changes: #7166. Please feel free to close mine if you plan to continue working on this PR

nvazquez avatar Feb 03 '23 01:02 nvazquez

Codecov Report

Merging #5579 (07d7c8c) into main (713a236) will increase coverage by 2.01%. The diff coverage is n/a.

:exclamation: Current head 07d7c8c differs from pull request most recent head 16b0002. Consider uploading reports for the commit 16b0002 to get more accurate results

@@             Coverage Diff              @@
##               main    #5579      +/-   ##
============================================
+ Coverage     10.60%   12.61%   +2.01%     
- Complexity     6849     8633    +1784     
============================================
  Files          2466     2711     +245     
  Lines        244549   257012   +12463     
  Branches      38262    40350    +2088     
============================================
+ Hits          25936    32427    +6491     
- Misses       215331   220471    +5140     
- Partials       3282     4114     +832     
Impacted Files Coverage Δ
...va/com/cloud/upgrade/dao/DatabaseAccessObject.java 0.00% <0.00%> (-97.50%) :arrow_down:
...ain/java/com/cloud/upgrade/dao/DbUpgradeUtils.java 0.00% <0.00%> (-92.31%) :arrow_down:
...in/java/com/cloud/upgrade/dao/Upgrade444to450.java 0.00% <0.00%> (-50.00%) :arrow_down:
...in/java/com/cloud/upgrade/dao/Upgrade453to460.java 0.00% <0.00%> (-50.00%) :arrow_down:
...java/com/cloud/upgrade/DatabaseUpgradeChecker.java 0.00% <0.00%> (-46.67%) :arrow_down:
...in/java/com/cloud/upgrade/dao/Upgrade431to440.java 0.00% <0.00%> (-40.00%) :arrow_down:
...in/java/com/cloud/upgrade/dao/Upgrade432to440.java 0.00% <0.00%> (-40.00%) :arrow_down:
...in/java/com/cloud/upgrade/dao/LegacyDbUpgrade.java 0.00% <0.00%> (-33.34%) :arrow_down:
.../com/cloud/storage/dao/StoragePoolTagsDaoImpl.java 12.90% <0.00%> (-32.26%) :arrow_down:
...va/com/cloud/upgrade/DatabaseVersionHierarchy.java 56.81% <0.00%> (-29.55%) :arrow_down:
... and 654 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Feb 09 '23 15:02 codecov[bot]

Closing this as https://github.com/apache/cloudstack/pull/7166 was merged.

rohityadavcloud avatar Apr 19 '23 07:04 rohityadavcloud