cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

pre-commit add Biome auto format ui/public/locales JSON

Open jbampton opened this issue 2 weeks ago • 1 comments

Description

Indentation in JSON is optional for the format to be valid, as whitespace is generally insignificant to JSON parsers. However, it is a best practice to indent JSON to make it human-readable and maintainable, especially for configuration files or debugging purposes.

Tools for Formatting: Most programming languages and code editors provide built-in tools or libraries to automatically format or "beautify" JSON with a specified indentation level

We had most of these JSON files with no indents and some with 2 spaces.

Some had minor whitespace inconsistencies in some places.

This PR closes #12244 and we can work on this Biome config more in future PRs.

For example rules can be set or disabled for individual file types etc.

Auto formatting saves time.

Really just whitespace standardization

refs #11277

If this PR is not preferred we may be able to use "flat" JSON for these file with no indents

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [X] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] Build/CI
  • [ ] Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [X] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

With pre-commit. First run the files were formatted and second time pre-commit passed.

Will just work on the GHA CI with pass or fail.

How did you try to break this feature and the system with this change?

jbampton avatar Dec 11 '25 19:12 jbampton

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 17.46%. Comparing base (f417c6b) to head (59e2d7f). :warning: Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12245   +/-   ##
=========================================
  Coverage     17.46%   17.46%           
+ Complexity    15516    15515    -1     
=========================================
  Files          5913     5913           
  Lines        529385   529385           
  Branches      64679    64679           
=========================================
+ Hits          92448    92449    +1     
+ Misses       426518   426517    -1     
  Partials      10419    10419           
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.52% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 11 '25 19:12 codecov[bot]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Dec 16 '25 11:12 github-actions[bot]