cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Cleanup userconcentratedpod_random and userconcentratedpod_firstfit allocation algorithms

Open sudo87 opened this issue 1 week ago • 2 comments

Description

This PR cleans up following vm and volume allocation algorithms which are redundant and behave same as “random" and “firstfit”, without the "userconcentrated" :

  1. userconcentratedpod_random
  2. userconcentratedpod_firstfit

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [x] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] Build/CI
  • [ ] Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sudo87 avatar Dec 11 '25 07:12 sudo87

Codecov Report

:x: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 17.46%. Comparing base (cfe9602) to head (3bbbb26).

Files with missing lines Patch % Lines
...ava/com/cloud/upgrade/dao/Upgrade42210to42300.java 0.00% 7 Missing :warning:
...in/java/com/cloud/upgrade/dao/Upgrade410to420.java 0.00% 2 Missing :warning:
...torage/allocator/AbstractStoragePoolAllocator.java 0.00% 0 Missing and 1 partial :warning:
...gent/manager/allocator/impl/FirstFitAllocator.java 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12233   +/-   ##
=========================================
  Coverage     17.45%   17.46%           
- Complexity    15513    15516    +3     
=========================================
  Files          5913     5913           
  Lines        529385   529392    +7     
  Branches      64679    64680    +1     
=========================================
+ Hits          92426    92448   +22     
+ Misses       426541   426525   -16     
- Partials      10418    10419    +1     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.52% <8.33%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 11 '25 07:12 codecov[bot]

I edtitted the description @sudo87, hope you like my version. looks good other wise but needs testing to make sure it is complete.

DaanHoogland avatar Dec 11 '25 08:12 DaanHoogland

@blueorangutan package

rajujith avatar Dec 16 '25 04:12 rajujith

@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 16 '25 04:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16051

blueorangutan avatar Dec 16 '25 06:12 blueorangutan