cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Prevent NPE when removing NIC from a stopped VM using service offering with CPU cap set

Open Pearl1594 opened this issue 2 weeks ago • 5 comments

Description

This PR fixes: #12225

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] Build/CI
  • [ ] Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [X] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Pearl1594 avatar Dec 10 '25 17:12 Pearl1594

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 16.21%. Comparing base (4348386) to head (3dac829).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #12232   +/-   ##
=========================================
  Coverage     16.21%   16.21%           
- Complexity    13353    13355    +2     
=========================================
  Files          5657     5657           
  Lines        498647   498648    +1     
  Branches      60533    60533           
=========================================
+ Hits          80863    80875   +12     
+ Misses       408771   408755   -16     
- Partials       9013     9018    +5     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.07% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 10 '25 17:12 codecov[bot]

@blueorangutan package

Pearl1594 avatar Dec 11 '25 15:12 Pearl1594

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 11 '25 15:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 16007

blueorangutan avatar Dec 11 '25 16:12 blueorangutan