Feature s390x multiarch support
Description
This PR adds multi-architecture support for IBM Z (s390x) to Apache CloudStack. The updates enable key CloudStack components to be built and run on both x86_64 (Intel/AMD) and s390x.
The implementation has been tested using s390x KVM hosts with full cross-architecture interoperability: x86_64 Management Server <=> s390x Agent
Compatibility and functionality have been validated across the following distributions: • RHEL • SLES • Ubuntu
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points:
- In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
- Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
- Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
- Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
- Be sure to read the CloudStack Coding Conventions. Apache CloudStack is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] (https://cloudstack.apache.org/mailing-lists.html) Slack: https://apachecloudstack.slack.com/
Codecov Report
:x: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 17.46%. Comparing base (3c64847) to head (1dcf314).
:warning: Report is 29 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java | 50.00% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #12214 +/- ##
============================================
+ Coverage 3.58% 17.46% +13.88%
- Complexity 0 15528 +15528
============================================
Files 445 5913 +5468
Lines 37552 529410 +491858
Branches 6914 64685 +57771
============================================
+ Hits 1347 92475 +91128
- Misses 36039 426513 +390474
- Partials 166 10422 +10256
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 3.58% <ø> (-0.01%) |
:arrow_down: |
| unittests | 18.52% <75.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@blueorangutan package
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15974
LGTM, great to see support for a new architecture @viddya673
@blueorangutan test
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-15025) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 47541 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12214-t15025-kvm-ol8.zip Smoke tests completed. 149 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|---|---|---|
| test_01_browser_migrate_template | Error |
65.64 | test_image_store_object_migration.py |
Awesome work, congrats on your first merged pull request!
@viddya673, will you be maintaining a regression suite on a s390 to make sure no regression creeps in from other code?
Yes — we’re working on adding GitHub Actions CI for s390x, now that it’s supported. This is currently a work in progress.