cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Support dedicating backup offerings to domains

Open Pearl1594 opened this issue 3 weeks ago • 30 comments

Description

This PR allows dedicating backup offerings to domains to be consistent in behaviour with other offerings

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] Build/CI
  • [ ] Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [X] Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Pearl1594 avatar Dec 04 '25 17:12 Pearl1594

Codecov Report

:x: Patch coverage is 31.61290% with 212 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 17.70%. Comparing base (2600965) to head (385f99b). :warning: Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
...stack/backup/dao/BackupOfferingDetailsDaoImpl.java 0.00% 52 Missing :warning:
...che/cloudstack/backup/BackupOfferingDetailsVO.java 0.00% 28 Missing :warning:
...rg/apache/cloudstack/backup/BackupManagerImpl.java 63.88% 15 Missing and 11 partials :warning:
...er/src/main/java/com/cloud/utils/DomainHelper.java 0.00% 19 Missing :warning:
...e/cloudstack/backup/dao/BackupOfferingDaoImpl.java 0.00% 13 Missing :warning:
...c/main/java/com/cloud/user/AccountManagerImpl.java 0.00% 13 Missing :warning:
...ver/src/main/java/com/cloud/acl/DomainChecker.java 47.61% 4 Missing and 7 partials :warning:
.../api/command/offering/DomainAndZoneIdResolver.java 78.72% 0 Missing and 10 partials :warning:
.../command/admin/backup/ImportBackupOfferingCmd.java 0.00% 7 Missing :warning:
...loudstack/api/response/BackupOfferingResponse.java 0.00% 6 Missing :warning:
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12194      +/-   ##
============================================
+ Coverage     17.57%   17.70%   +0.13%     
- Complexity    15550    15933     +383     
============================================
  Files          5913     5918       +5     
  Lines        529427   541258   +11831     
  Branches      64677    69524    +4847     
============================================
+ Hits          93024    95808    +2784     
- Misses       425940   434754    +8814     
- Partials      10463    10696     +233     
Flag Coverage Δ
uitests 3.55% <ø> (-0.04%) :arrow_down:
unittests 18.76% <31.61%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 04 '25 17:12 codecov[bot]

@blueorangutan package

Pearl1594 avatar Dec 08 '25 16:12 Pearl1594

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 08 '25 16:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15952

blueorangutan avatar Dec 08 '25 18:12 blueorangutan

@blueorangutan test

Pearl1594 avatar Dec 08 '25 19:12 Pearl1594

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Dec 08 '25 19:12 blueorangutan

[SF] Trillian Build Failed (tid-14922)

blueorangutan avatar Dec 08 '25 20:12 blueorangutan

@blueorangutan package

Pearl1594 avatar Dec 09 '25 00:12 Pearl1594

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 09 '25 00:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15953

blueorangutan avatar Dec 09 '25 01:12 blueorangutan

@blueorangutan test

Pearl1594 avatar Dec 09 '25 02:12 Pearl1594

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Dec 09 '25 02:12 blueorangutan

[SF] Trillian Build Failed (tid-14923)

blueorangutan avatar Dec 09 '25 02:12 blueorangutan

@blueorangutan test

Pearl1594 avatar Dec 09 '25 13:12 Pearl1594

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Dec 09 '25 13:12 blueorangutan

[SF] Trillian Build Failed (tid-14946)

blueorangutan avatar Dec 09 '25 14:12 blueorangutan

@blueorangutan package

Pearl1594 avatar Dec 09 '25 18:12 Pearl1594

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 09 '25 18:12 blueorangutan

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15969

blueorangutan avatar Dec 09 '25 19:12 blueorangutan

@blueorangutan package

Pearl1594 avatar Dec 10 '25 13:12 Pearl1594

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 10 '25 13:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15976

blueorangutan avatar Dec 10 '25 15:12 blueorangutan

@blueorangutan test

Pearl1594 avatar Dec 10 '25 15:12 Pearl1594

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Dec 10 '25 15:12 blueorangutan

[SF] Trillian Build Failed (tid-14958)

blueorangutan avatar Dec 10 '25 15:12 blueorangutan

[SF] Trillian test result (tid-14963) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 61908 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12194-t14963-kvm-ol8.zip Smoke tests completed. 147 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 68.93 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 21.22 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 333.36 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 333.37 test_vm_life_cycle.py
test_08_migrate_vm Error 16.74 test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success Error 71.80 test_vm_strict_host_tags.py
test_01_redundant_vpc_site2site_vpn Failure 390.27 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 251.56 test_vpc_vpn.py

blueorangutan avatar Dec 11 '25 09:12 blueorangutan

@blueorangutan test

Pearl1594 avatar Dec 11 '25 16:12 Pearl1594

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Dec 11 '25 16:12 blueorangutan

[SF] Trillian test result (tid-14972) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 48046 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12194-t14972-kvm-ol8.zip Smoke tests completed. 140 look OK, 5 have errors, 5 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_DeployVmAntiAffinityGroup_in_project Error 72.06 test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup Error 10.64 test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster Failure 31.75 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.06 test_kubernetes_clusters.py
test_12_test_deploy_cluster_different_offerings_per_node_type Failure 73.69 test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity Failure 75.15 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 22.13 test_nonstrict_affinity_group.py
ContextSuite context=TestMigrateVMStrictTags>:setup Error 0.00 test_vm_strict_host_tags.py
all_test_vpc_vpn Skipped --- test_vpc_vpn.py
all_test_webhook_delivery Skipped --- test_webhook_delivery.py
all_test_webhook_lifecycle Skipped --- test_webhook_lifecycle.py
all_test_host_maintenance Skipped --- test_host_maintenance.py
all_test_hostha_kvm Skipped --- test_hostha_kvm.py

blueorangutan avatar Dec 12 '25 07:12 blueorangutan

@blueorangutan package

Pearl1594 avatar Dec 16 '25 19:12 Pearl1594