cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

engine/schema: prepend algorithm to checksum during systemvm template registration

Open weizhouapache opened this issue 1 month ago • 13 comments

Description

This PR fixes #12042

No idea how to reproduce the issue. However, 2 users have faced the same issue which seems to be caused by missing {SHA-512} algorithm of checksum value.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] Build/CI
  • [ ] Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache avatar Nov 28 '25 13:11 weizhouapache

Codecov Report

:x: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 17.56%. Comparing base (e23c7ef) to head (97424f2). :warning: Report is 1 commits behind head on 4.22.

Files with missing lines Patch % Lines
...apache/cloudstack/utils/security/DigestHelper.java 0.00% 11 Missing :warning:
...om/cloud/upgrade/SystemVmTemplateRegistration.java 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #12165   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15545    15547    +2     
=========================================
  Files          5910     5910           
  Lines        529123   529134   +11     
  Branches      64627    64629    +2     
=========================================
+ Hits          92937    92950   +13     
+ Misses       425733   425730    -3     
- Partials      10453    10454    +1     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <0.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 28 '25 13:11 codecov[bot]

@blueorangutan package

DaanHoogland avatar Nov 28 '25 14:11 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Nov 28 '25 14:11 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15859

blueorangutan avatar Nov 28 '25 15:11 blueorangutan

@blueorangutan test keepEnv

weizhouapache avatar Nov 28 '25 15:11 weizhouapache

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Nov 28 '25 15:11 blueorangutan

[SF] Trillian Build Failed (tid-14887)

blueorangutan avatar Nov 28 '25 16:11 blueorangutan

@blueorangutan test keepEnv

weizhouapache avatar Nov 28 '25 17:11 weizhouapache

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Nov 28 '25 17:11 blueorangutan

[SF] Trillian test result (tid-14889) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 53254 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12165-t14889-kvm-ol8.zip Smoke tests completed. 149 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Nov 29 '25 08:11 blueorangutan

@blueorangutan package

weizhouapache avatar Dec 09 '25 08:12 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 09 '25 08:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15960

blueorangutan avatar Dec 09 '25 11:12 blueorangutan