Fix that Sensitive information logged in SshHelper.sshExecute method
Description
This PR fixes that Sensitive information logged in SshHelper.sshExecute method. Fixes: #12025
Codecov Report
:x: Patch coverage is 88.00000% with 6 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 16.18%. Comparing base (e90e436) to head (7460a5c).
:warning: Report is 5 commits behind head on 4.20.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...s/src/main/java/com/cloud/utils/ssh/SshHelper.java | 88.00% | 5 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 4.20 #12026 +/- ##
============================================
- Coverage 16.18% 16.18% -0.01%
- Complexity 13305 13307 +2
============================================
Files 5657 5657
Lines 498466 498506 +40
Branches 60491 60497 +6
============================================
+ Hits 80696 80698 +2
- Misses 408789 408826 +37
- Partials 8981 8982 +1
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.00% <ø> (ø) |
|
| unittests | 17.04% <88.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@blueorangutan package
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15700
some errors @YLChen-007 ,
09:30:14 [ERROR] SshHelperTest.sanitizeForLoggingMasksLongPasswordAssignments:169 Sanitized command should retain assignment
09:30:14 [ERROR] SshHelperTest.sanitizeForLoggingMasksQuotedPasswordFlag:159 Sanitized command should retain quoted flag
I am not sure if the tests should be adjusted or your code.
@blueorangutan package
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15714
@blueorangutan test
@blueorangutan package
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15991