cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Show time correctly in the backup schedule UI

Open abh1sar opened this issue 1 month ago • 16 comments

Description

This PR fixes #11928

  1. Display time in human readable format
  2. Disable the interval for which a schedule is already created as one interval can only have one schedule.

The behaviour is similar to the Create Recurring Snapshots UI.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] Build/CI
  • [ ] Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [x] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

https://github.com/user-attachments/assets/2438c3d9-c2f5-4785-835c-195b0e95f7dd

How did you try to break this feature and the system with this change?

abh1sar avatar Nov 07 '25 04:11 abh1sar

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 17.56%. Comparing base (ac8c200) to head (982298e). :warning: Report is 42 commits behind head on 4.22.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12012      +/-   ##
============================================
- Coverage     17.56%   17.56%   -0.01%     
- Complexity    15544    15545       +1     
============================================
  Files          5909     5910       +1     
  Lines        529059   529208     +149     
  Branches      64617    64661      +44     
============================================
- Hits          92941    92940       -1     
- Misses       425664   425810     +146     
- Partials      10454    10458       +4     
Flag Coverage Δ
uitests 3.58% <ø> (-0.01%) :arrow_down:
unittests 18.63% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 07 '25 04:11 codecov[bot]

@blueorangutan ui

DaanHoogland avatar Nov 07 '25 08:11 DaanHoogland

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Nov 07 '25 08:11 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12012 (QA-JID-792)

blueorangutan avatar Nov 07 '25 08:11 blueorangutan

@blueorangutan ui

abh1sar avatar Nov 07 '25 09:11 abh1sar

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Nov 07 '25 09:11 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12012 (QA-JID-793)

blueorangutan avatar Nov 07 '25 10:11 blueorangutan

@blueorangutan ui

RosiKyu avatar Dec 10 '25 16:12 RosiKyu

@rosi-shapeblue a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Dec 10 '25 16:12 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12012 (QA-JID-828)

blueorangutan avatar Dec 10 '25 16:12 blueorangutan

@blueorangutan package

RosiKyu avatar Dec 10 '25 17:12 RosiKyu

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 10 '25 17:12 blueorangutan

@blueorangutan package

RosiKyu avatar Dec 10 '25 18:12 RosiKyu

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 10 '25 18:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15985

blueorangutan avatar Dec 10 '25 19:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15984

blueorangutan avatar Dec 10 '25 19:12 blueorangutan

@blueorangutan ui

abh1sar avatar Dec 16 '25 10:12 abh1sar

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Dec 16 '25 10:12 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12012 (QA-JID-830)

blueorangutan avatar Dec 16 '25 10:12 blueorangutan

Thanks for testing @RosiKyu I have fixed the issue. Same issue was present in Scheduled volume snapshot as well. I have fixed it there as well. It would be great if you could take a look at that also.

abh1sar avatar Dec 16 '25 11:12 abh1sar

@blueorangutan package

RosiKyu avatar Dec 16 '25 22:12 RosiKyu

@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 16 '25 22:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16063

blueorangutan avatar Dec 16 '25 23:12 blueorangutan