cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard
verified publisher icon apache

small refactors on account manager

Open DaanHoogland opened this issue 2 months ago • 6 comments

Description

This PR does some small refactors encountered during trouble shooting. ...

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [x] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] Build/CI
  • [ ] Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [x] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

DaanHoogland avatar Oct 03 '25 10:10 DaanHoogland

Codecov Report

:x: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 17.45%. Comparing base (f417c6b) to head (10fa999).

Files with missing lines Patch % Lines
...c/main/java/com/cloud/user/AccountManagerImpl.java 0.00% 14 Missing :warning:
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11784      +/-   ##
============================================
- Coverage     17.46%   17.45%   -0.01%     
+ Complexity    15516    15514       -2     
============================================
  Files          5913     5913              
  Lines        529385   529384       -1     
  Branches      64679    64679              
============================================
- Hits          92448    92428      -20     
- Misses       426518   426539      +21     
+ Partials      10419    10417       -2
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.51% <0.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 03 '25 10:10 codecov[bot]

@blueorangutan package

DaanHoogland avatar Dec 08 '25 15:12 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 08 '25 15:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15961

blueorangutan avatar Dec 09 '25 11:12 blueorangutan

[SF] Trillian test result (tid-14945) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 53824 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11784-t14945-kvm-ol8.zip Smoke tests completed. 142 look OK, 8 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_primary_storage_nfs Error 0.20 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.31 test_primary_storage.py
test_01_primary_storage_scope_change Error 0.12 test_primary_storage_scope.py
test_01_secure_vm_migration Error 212.85 test_vm_life_cycle.py
test_01_secure_vm_migration Error 212.86 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 0.02 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 0.01 test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration Error 0.01 test_vm_life_cycle.py
test_08_migrate_vm Error 7.43 test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success Error 64.00 test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure Error 11.74 test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success Error 11.72 test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure Error 11.77 test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success Error 11.77 test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure Error 12.83 test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags Error 11.71 test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags Error 17.85 test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success Error 12.76 test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success Error 16.88 test_vm_strict_host_tags.py
test_01_verify_ipv6_vpc Error 51.38 test_vpc_ipv6.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Error 111.80 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Error 111.61 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Error 55.18 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 112.83 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 58.48 test_vpc_redundant.py
test_02_VPC_default_routes Error 64.55 test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn Failure 51.40 test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options Failure 51.42 test_vpc_vpn.py

blueorangutan avatar Dec 10 '25 05:12 blueorangutan

[SF] Trillian test result (tid-14967) Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 55823 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11784-t14967-kvm-ol8.zip Smoke tests completed. 146 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_uservm_host_control_state Failure 16.95 test_host_control_state.py
ContextSuite context=TestHostControlState>:teardown Error 32.52 test_host_control_state.py
test_01_vpn_usage Error 1.08 test_usage.py
test_01_migrate_VM_and_root_volume Error 146.94 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 31.81 test_vm_life_cycle.py
test_01_secure_vm_migration Error 241.43 test_vm_life_cycle.py
test_hostha_enable_ha_when_host_disabled Error 2.78 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 305.93 test_hostha_kvm.py

blueorangutan avatar Dec 12 '25 02:12 blueorangutan