Skip removal of offerings if in use during domain removal

[sudo87]

Description

This PR fixes https://github.com/apache/cloudstack/issues/11502

1. Prevent service offering update to specific domains if any instance for the offering are outside of those
2. Removal of offerings is skipped if it is in use by any Instance.

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] Build/CI
• [ ] Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [ ] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

1. Create a compute offering L1 at Root Domain
2. Create a domain d1
3. Create an instance vm1 with L1 at root domain level
4. Try updating service offering domain to d1, shouldn't be allowed
5. Destroy instance vm1
6. Update of domain d1 for service offering works

How did you try to break this feature and the system with this change?

[codecov[bot]]

Codecov Report

:x: Patch coverage is 8.51064% with 43 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 16.18%. Comparing base (d53b6db) to head (a487eba). :warning: Report is 18 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java	0.00%	26 Missing :warning:
...rc/main/java/com/cloud/user/DomainManagerImpl.java	0.00%	8 Missing :warning:
...main/java/com/cloud/storage/dao/VolumeDaoImpl.java	40.00%	6 Missing :warning:
.../cloud/configuration/ConfigurationManagerImpl.java	0.00%	3 Missing :warning:

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #11780      +/-   ##
============================================
- Coverage     16.19%   16.18%   -0.01%     
  Complexity    13306    13306              
============================================
  Files          5657     5657              
  Lines        498467   498510      +43     
  Branches      60491    60492       +1     
============================================
+ Hits          80702    80707       +5     
- Misses       408783   408823      +40     
+ Partials       8982     8980       -2     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.04% <8.51%> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sudo87]

@blueorangutan package

[blueorangutan]

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15304

[sudo87]

@blueorangutan package

[blueorangutan]

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15628

[RosiKyu]

@blueorangutan package

[blueorangutan]

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15989

[sudo87]

@blueorangutan package

[blueorangutan]

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15996

[sudo87]

@blueorangutan test

[blueorangutan]

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-14968)

[sudo87]

Thank you, @RosiKyu, for taking the time to review and for validating the functionality.

On Black UI rendering issue, I will take a look at the code changes. Although that seems to be related to UI packaging issue.

[RosiKyu]

@blueorangutan package

[blueorangutan]

@RosiKyu a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16048

[RosiKyu]

@sudo87 , @DaanHoogland - the rendering issue does not appear to be caused by the PR code. Rebuilding the packages with the PR code resolved it, so I believe this can be safely merged.

[DaanHoogland]

@shwstppr can you have another look?