cleanup LDAP code according to warnings

[DaanHoogland]

Description

This PR was part of investigation into the current LDAP workings, to find out that the issue under investigation was a user issue. I think this can be merged, but it has no functional changes.

Types of changes

• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] Enhancement (improves an existing feature and functionality)
• [x] Cleanup (Code refactoring and cleanup, that may add test cases)
• [ ] build/CI
• [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• [ ] Major
• [ ] Minor

Bug Severity

• [ ] BLOCKER
• [ ] Critical
• [ ] Major
• [ ] Minor
• [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov[bot]]

Codecov Report

:x: Patch coverage is 41.17647% with 110 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 17.50%. Comparing base (2ac2e5b) to head (2983839). :warning: Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...va/org/apache/cloudstack/ldap/LdapManagerImpl.java	0.00%	52 Missing :warning:
...pache/cloudstack/ldap/OpenLdapUserManagerImpl.java	5.88%	16 Missing :warning:
.../org/apache/cloudstack/ldap/LdapConfiguration.java	74.35%	9 Missing and 1 partial :warning:
...org/apache/cloudstack/ldap/LdapContextFactory.java	0.00%	7 Missing :warning:
.../org/apache/cloudstack/ldap/LdapAuthenticator.java	40.00%	5 Missing and 1 partial :warning:
...che/cloudstack/api/command/LdapImportUsersCmd.java	58.33%	5 Missing :warning:
...e/cloudstack/api/command/LinkAccountToLdapCmd.java	0.00%	3 Missing :warning:
...oudstack/api/command/LdapListConfigurationCmd.java	0.00%	2 Missing :warning:
...pache/cloudstack/api/command/LdapListUsersCmd.java	92.30%	1 Missing and 1 partial :warning:
...ache/cloudstack/api/command/LdapUserSearchCmd.java	0.00%	2 Missing :warning:
... and 4 more

Additional details and impacted files

@@             Coverage Diff              @@
##              main   #11436       +/-   ##
============================================
+ Coverage     3.58%   17.50%   +13.91%     
- Complexity       0    15564    +15564     
============================================
  Files          445     5914     +5469     
  Lines        37571   529642   +492071     
  Branches      6921    64702    +57781     
============================================
+ Hits          1347    92691    +91344     
- Misses       36058   426503   +390445     
- Partials       166    10448    +10282     

Flag	Coverage Δ
uitests	3.58% <ø> (ø)
unittests	18.56% <41.17%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16076

[blueorangutan]

[SF] Trillian test result (tid-15017) Environment: kvm-ol9 (x2), zone: Advanced Networking with Mgmt server ol9 Total time taken: 55148 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11436-t15017-kvm-ol9.zip Smoke tests completed. 149 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	Failure	26.65	test_kubernetes_clusters.py