cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

api,server: allow configuring repetitive alerts

Open shwstppr opened this issue 5 months ago • 14 comments

Description

Fixes #6613

Introduces support for configuring additional alert types that can be published repeatedly, beyond the default set.

Operators can now use the dynamic configuration alert.allowed.repetitive.types to specify a comma-separated list of alert type names that should be allowed for repetitive publication.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr avatar Jul 29 '25 08:07 shwstppr

Codecov Report

:x: Patch coverage is 83.95062% with 13 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 17.50%. Comparing base (a60c8ca) to head (0299cfc). :warning: Report is 343 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/java/com/cloud/alert/AlertManagerImpl.java 82.75% 2 Missing and 3 partials :warning:
...java/org/apache/cloudstack/alert/AlertService.java 93.47% 3 Missing :warning:
...che/cloudstack/api/response/AlertTypeResponse.java 0.00% 3 Missing :warning:
.../api/command/admin/resource/ListAlertTypesCmd.java 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11325      +/-   ##
============================================
+ Coverage     17.35%   17.50%   +0.15%     
- Complexity    15189    15481     +292     
============================================
  Files          5883     5885       +2     
  Lines        524514   535880   +11366     
  Branches      64007    68731    +4724     
============================================
+ Hits          91013    93791    +2778     
- Misses       423216   431552    +8336     
- Partials      10285    10537     +252     
Flag Coverage Δ
uitests 3.86% <ø> (+0.22%) :arrow_up:
unittests 18.52% <83.95%> (+0.13%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 29 '25 09:07 codecov[bot]

@blueorangutan package

shwstppr avatar Jul 31 '25 05:07 shwstppr

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 31 '25 05:07 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14484

blueorangutan avatar Jul 31 '25 06:07 blueorangutan

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Jul 31 '25 11:07 github-actions[bot]

@blueorangutan package

shwstppr avatar Aug 05 '25 10:08 shwstppr

@blueorangutan package

DaanHoogland avatar Aug 05 '25 14:08 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Aug 05 '25 14:08 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14560

blueorangutan avatar Aug 05 '25 16:08 blueorangutan

@blueorangutan test

shwstppr avatar Aug 08 '25 19:08 shwstppr

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Aug 08 '25 19:08 blueorangutan

[SF] Trillian test result (tid-14049) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51469 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11325-t14049-kvm-ol8.zip Smoke tests completed. 146 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Aug 09 '25 10:08 blueorangutan

@shwstppr , anything more needed here?

DaanHoogland avatar Dec 12 '25 09:12 DaanHoogland

@DaanHoogland no, just another review

shwstppr avatar Dec 12 '25 09:12 shwstppr