cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Change disk-only VM snapshot removal message

Open JoaoJandre opened this issue 5 months ago • 4 comments

Description

This PR changes the warning given to users when deleting disk-only VM snapshots on KVM. When deleting disk-only VM snapshots on KVM, the VM is not paused.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [X] Minor
  • [ ] Trivial

Screenshots (if appropriate):

When deleting Disk-only VM snapshot: image

When deleting Disk And Memory VM snapshot: image

How Has This Been Tested?

Created two VM snapshots, one with and one without memory. I checked that the messages were being shown accordingly.

JoaoJandre avatar Jul 11 '25 13:07 JoaoJandre

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 17.36%. Comparing base (8e4fe1c) to head (e933434). :warning: Report is 476 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11182      +/-   ##
============================================
+ Coverage     16.57%   17.36%   +0.78%     
- Complexity    13988    15238    +1250     
============================================
  Files          5745     5888     +143     
  Lines        510847   525740   +14893     
  Branches      62140    64164    +2024     
============================================
+ Hits          84696    91285    +6589     
- Misses       416677   424154    +7477     
- Partials       9474    10301     +827     
Flag Coverage Δ
uitests 3.63% <ø> (-0.28%) :arrow_down:
unittests 18.40% <ø> (+0.92%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 11 '25 13:07 codecov[bot]

@blueorangutan ui

DaanHoogland avatar Dec 12 '25 09:12 DaanHoogland

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Dec 12 '25 09:12 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11182 (QA-JID-829)

blueorangutan avatar Dec 12 '25 09:12 blueorangutan