cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Switch BouncyCastle dependencies to jdk18on for improved security

Open sroopsai opened this issue 5 months ago • 27 comments
trafficstars

Description

This PR fixes #10954

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

sroopsai avatar Jun 16 '25 13:06 sroopsai

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 16.60%. Comparing base (6aaaa83) to head (7827812). :warning: Report is 215 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11034   +/-   ##
=========================================
  Coverage     16.60%   16.60%           
  Complexity    13925    13925           
=========================================
  Files          5730     5730           
  Lines        508224   508224           
  Branches      61789    61789           
=========================================
  Hits          84388    84388           
  Misses       414401   414401           
  Partials       9435     9435           
Flag Coverage Δ
uitests 3.93% <ø> (ø)
unittests 17.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 16 '25 14:06 codecov[bot]

@blueorangutan package

DaanHoogland avatar Jun 16 '25 14:06 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 16 '25 14:06 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13795

blueorangutan avatar Jun 16 '25 15:06 blueorangutan

@blueorangutan package

weizhouapache avatar Jun 16 '25 15:06 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 16 '25 15:06 blueorangutan

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13797

blueorangutan avatar Jun 16 '25 16:06 blueorangutan

@blueorangutan package

weizhouapache avatar Jun 16 '25 19:06 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 16 '25 19:06 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13799

blueorangutan avatar Jun 16 '25 20:06 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13810

blueorangutan avatar Jun 17 '25 07:06 blueorangutan

@blueorangutan package

weizhouapache avatar Jun 17 '25 09:06 weizhouapache

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 17 '25 09:06 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13813

blueorangutan avatar Jun 17 '25 10:06 blueorangutan

@blueorangutan test matrix

DaanHoogland avatar Jun 17 '25 10:06 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan avatar Jun 17 '25 10:06 blueorangutan

[SF] Trillian Build Failed (tid-13545)

blueorangutan avatar Jun 17 '25 10:06 blueorangutan

[SF] Trillian Build Failed (tid-13544)

blueorangutan avatar Jun 17 '25 10:06 blueorangutan

[SF] Trillian Build Failed (tid-13546)

blueorangutan avatar Jun 17 '25 11:06 blueorangutan

[SF] Trillian Build Failed (tid-13543)

blueorangutan avatar Jun 17 '25 11:06 blueorangutan

system vms are not coming up need some more investigation

weizhouapache avatar Jun 17 '25 12:06 weizhouapache

there are some smoke test failures, which mean there might be some regression @sroopsai @DaanHoogland @sureshanaparti

weizhouapache avatar Jun 17 '25 12:06 weizhouapache

[SF] Trillian Build Failed (tid-13549)

blueorangutan avatar Jun 17 '25 15:06 blueorangutan

@sroopsai I moved this PR to draft, as there are more changes required.

weizhouapache avatar Jun 17 '25 17:06 weizhouapache

[SF] Trillian Build Failed (tid-13556)

blueorangutan avatar Jun 18 '25 11:06 blueorangutan

@sroopsai will you investigate the issues ?

weizhouapache avatar Jun 18 '25 13:06 weizhouapache

@weizhouapache I checked the changes once again. I assume I didn't miss a single dependency switch over. I can investigate, but since I am new to Cloudstack, I need some help to start.

sroopsai avatar Jun 18 '25 13:06 sroopsai

@sroopsai , first step would be to see if you can have it running in the simulator and run some tests in there.

some hints but some may be very old:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+integration https://cwiki.apache.org/confluence/display/CLOUDSTACK/Setting+up+the+CloudStack+test+environment https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes%2C+using+Simulator

there is also the hackerbook, for a more extensive tutorial

DaanHoogland avatar Jul 10 '25 09:07 DaanHoogland

we will work in pr https://github.com/apache/cloudstack/pull/11201

weizhouapache avatar Aug 21 '25 13:08 weizhouapache