cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Add yamllint pre-commit hook for YAML file standardization

Open vanzan01 opened this issue 6 months ago • 9 comments

Add yamllint hook to .pre-commit-config.yaml to standardize YAML files across the project. Created .yamllint.yml configuration with relaxed rules to accommodate existing files. Fixed colon spacing in .asf.yaml to pass yamllint checks.

Changes

  • Add yamllint hook to .pre-commit-config.yaml
  • Create .yamllint.yml configuration with relaxed rules for existing files
  • Fix colon spacing in .asf.yaml to pass yamllint checks

Test plan

  • [x] yamllint runs successfully on existing YAML files
  • [x] Configuration allows existing files to pass with minimal changes
  • [x] Fixed formatting issue in .asf.yaml

Closes #10974

vanzan01 avatar Jun 12 '25 15:06 vanzan01

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points:

  • In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
  • Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
  • Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
  • Be sure to read the CloudStack Coding Conventions. Apache CloudStack is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] (https://cloudstack.apache.org/mailing-lists.html) Slack: https://apachecloudstack.slack.com/

boring-cyborg[bot] avatar Jun 12 '25 15:06 boring-cyborg[bot]

@blueorangutan package

DaanHoogland avatar Jun 14 '25 09:06 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 14 '25 09:06 blueorangutan

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 17.39%. Comparing base (a466750) to head (2972ea2). :warning: Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main   #11017       +/-   ##
============================================
+ Coverage     3.62%   17.39%   +13.77%     
- Complexity       0    15284    +15284     
============================================
  Files          441     5889     +5448     
  Lines        37136   526184   +489048     
  Branches      6808    64242    +57434     
============================================
+ Hits          1346    91540    +90194     
- Misses       35626   424299   +388673     
- Partials       164    10345    +10181     
Flag Coverage Δ
uitests 3.62% <ø> (ø)
unittests 18.44% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 14 '25 09:06 codecov[bot]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13778

blueorangutan avatar Jun 14 '25 10:06 blueorangutan

@blueorangutan package

DaanHoogland avatar Jun 16 '25 12:06 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 16 '25 12:06 blueorangutan

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 13794

blueorangutan avatar Jun 16 '25 14:06 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13815

blueorangutan avatar Jun 17 '25 11:06 blueorangutan

@blueorangutan package

sureshanaparti avatar Jul 14 '25 11:07 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 14 '25 11:07 blueorangutan

@jbampton , are your concerns addressed on this PR?

DaanHoogland avatar Jul 14 '25 11:07 DaanHoogland

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14170

blueorangutan avatar Jul 14 '25 16:07 blueorangutan

@blueorangutan package

jbampton avatar Sep 19 '25 15:09 jbampton

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 19 '25 15:09 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15109

blueorangutan avatar Sep 19 '25 17:09 blueorangutan

3 approvals and the checks pass. No code changes just config files and minor whitespace.

Merging.

jbampton avatar Sep 19 '25 17:09 jbampton

Awesome work, congrats on your first merged pull request!

boring-cyborg[bot] avatar Sep 19 '25 17:09 boring-cyborg[bot]