cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

[WIP] Configuration settings validation improvements

Open sureshanaparti opened this issue 7 months ago • 5 comments

Description

This PR improves configuration settings validation and some code refactoring.

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti avatar Jun 10 '25 10:06 sureshanaparti

@blueorangutan package

sureshanaparti avatar Jun 10 '25 10:06 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 10 '25 10:06 blueorangutan

Codecov Report

Attention: Patch coverage is 41.02564% with 23 lines in your changes missing coverage. Please review.

Project coverage is 15.18%. Comparing base (0d5a0ea) to head (b7a23e2).

Files with missing lines Patch % Lines
.../cloud/configuration/ConfigurationManagerImpl.java 35.29% 20 Missing and 2 partials :warning:
...om/cloud/network/firewall/FirewallManagerImpl.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10998   +/-   ##
=========================================
  Coverage     15.18%   15.18%           
+ Complexity    11365    11364    -1     
=========================================
  Files          5416     5417    +1     
  Lines        475890   475906   +16     
  Branches      58093    58097    +4     
=========================================
+ Hits          72254    72260    +6     
- Misses       395550   395560   +10     
  Partials       8086     8086           
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.91% <41.02%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 10 '25 10:06 codecov[bot]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13689

blueorangutan avatar Jun 10 '25 11:06 blueorangutan