cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

misc: fix typo `sercurity` -> `security`

Open jbampton opened this issue 5 months ago • 13 comments
trafficstars

Description

This PR fixes a typo 73 times

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [X] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

jbampton avatar Jun 05 '25 15:06 jbampton

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.74%. Comparing base (6d5cefd) to head (db19ec0). Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10966      +/-   ##
============================================
- Coverage     16.74%   16.74%   -0.01%     
+ Complexity    14065    14063       -2     
============================================
  Files          5724     5724              
  Lines        507787   507787              
  Branches      61733    61733              
============================================
- Hits          85046    85039       -7     
- Misses       413258   413265       +7     
  Partials       9483     9483              
Flag Coverage Δ
uitests 3.89% <ø> (ø)
unittests 17.66% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 05 '25 15:06 codecov[bot]

@bernardodemarco @weizhouapache , did you test this PR?

DaanHoogland avatar Jun 09 '25 14:06 DaanHoogland

@blueorangutan package

DaanHoogland avatar Jun 09 '25 14:06 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 09 '25 14:06 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13676

blueorangutan avatar Jun 09 '25 15:06 blueorangutan

@bernardodemarco @weizhouapache , did you test this PR?

I did not. @DaanHoogland

weizhouapache avatar Jun 09 '25 16:06 weizhouapache

@bernardodemarco @weizhouapache , did you test this PR?

I did not. @DaanHoogland

@DaanHoogland, neither did I. Since the typo fixes consist of renaming integration test variables and correcting a comment (plugins/hypervisors/baremetal/src/main/resources/security_group_agent/cs-sgagent), I believe it is only necessary to run the integration tests pipeline. If no errors are returned, it should be ready to merge.

bernardodemarco avatar Jun 10 '25 00:06 bernardodemarco

@blueorangutan test keepEnv

DaanHoogland avatar Jun 11 '25 17:06 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Jun 11 '25 17:06 blueorangutan

[SF] Trillian test result (tid-13503) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 54405 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10966-t13503-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Jun 12 '25 09:06 blueorangutan

@blueorangutan help

DaanHoogland avatar Jun 13 '25 14:06 DaanHoogland

@DaanHoogland [SL] I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups] Mgmt OS options: ['ol8', 'ol9', 'debian12', 'rocky8', 'alma9', 'suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24'] Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-debian12', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'vmware-80u2', 'vmware-80u3', 'vmware-80u3e', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xenserver-84', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82', 'xcpng83'] Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command. when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu. When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced) Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar', 'sudo87', 'rosi-shapeblue']

blueorangutan avatar Jun 13 '25 14:06 blueorangutan

running the component tests for a change.

DaanHoogland avatar Jun 13 '25 17:06 DaanHoogland

@blueorangutan package

DaanHoogland avatar Jul 23 '25 12:07 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 23 '25 12:07 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14315

blueorangutan avatar Jul 23 '25 13:07 blueorangutan

@blueorangutan test keepEnv

DaanHoogland avatar Jul 23 '25 14:07 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Jul 23 '25 14:07 blueorangutan

[SF] Trillian test result (tid-13861) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57064 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10966-t13861-kvm-ol8.zip Smoke tests completed. 142 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Jul 24 '25 06:07 blueorangutan

the errors are in test_routers and in test_cpu_domain_limits. No relation to the changed files.

DaanHoogland avatar Jul 24 '25 07:07 DaanHoogland