cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

Add special Icon to Shared FileSystem Instances

Open abh1sar opened this issue 7 months ago • 5 comments

Description

Shared FileSystem Instance and Volumes show up in the common Instance and Volume Lists, but they behave somewhat differently from normal instances and volumes in terms of actions supported.

This PR adds the change which makes it easier to identify a Shared FileSystem Instance in the Instance list by using the Shared FileSystem Icon shown on the main menu. Previously it used the generic Debian icon. This PR also adds a prefix to volumes used by Shared FileSystems, again to make them easier to identify among the list of all volumes.

Before: Screenshot 2025-05-13 at 5 03 54 PM Screenshot 2025-05-13 at 5 04 17 PM After: Screenshot 2025-05-13 at 5 04 46 PM Screenshot 2025-05-13 at 5 16 27 PM

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] Enhancement (improves an existing feature and functionality)
  • [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [x] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

abh1sar avatar May 13 '25 11:05 abh1sar

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 16.14%. Comparing base (41de0b9) to head (96cb71d). Report is 28 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10857   +/-   ##
=========================================
  Coverage     16.14%   16.14%           
- Complexity    13255    13258    +3     
=========================================
  Files          5657     5657           
  Lines        497903   497918   +15     
  Branches      60375    60377    +2     
=========================================
+ Hits          80395    80407   +12     
- Misses       408549   408552    +3     
  Partials       8959     8959           
Flag Coverage Δ
uitests 4.00% <ø> (+<0.01%) :arrow_up:
unittests 16.99% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 13 '25 11:05 codecov[bot]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Jun 10 '25 10:06 github-actions[bot]

@blueorangutan ui

abh1sar avatar Jun 11 '25 12:06 abh1sar

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan avatar Jun 11 '25 12:06 blueorangutan

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10857 (QA-JID-644)

blueorangutan avatar Jun 11 '25 12:06 blueorangutan

@blueorangutan package

abh1sar avatar Jul 08 '25 09:07 abh1sar

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 08 '25 10:07 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14092

blueorangutan avatar Jul 08 '25 12:07 blueorangutan

LGTM. Verification passed.

  • Instances have a special icon to indicate they are shared file system Instances
  • Volumes used by Shared FileSystems have a "shared-" prefix
Screenshot from 2025-07-16 14-50-45 Screenshot from 2025-07-16 14-50-51 Screenshot from 2025-07-16 14-50-57 Screenshot from 2025-07-16 14-51-02

RosiKyu avatar Jul 16 '25 11:07 RosiKyu

@blueorangutan package

sureshanaparti avatar Jul 22 '25 09:07 sureshanaparti

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jul 22 '25 09:07 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14293

blueorangutan avatar Jul 22 '25 10:07 blueorangutan

@blueorangutan test

sureshanaparti avatar Jul 22 '25 11:07 sureshanaparti

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Jul 22 '25 11:07 blueorangutan

[SF] Trillian test result (tid-13839) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 63271 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10857-t13839-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Jul 23 '25 05:07 blueorangutan