Add special Icon to Shared FileSystem Instances
Description
Shared FileSystem Instance and Volumes show up in the common Instance and Volume Lists, but they behave somewhat differently from normal instances and volumes in terms of actions supported.
This PR adds the change which makes it easier to identify a Shared FileSystem Instance in the Instance list by using the Shared FileSystem Icon shown on the main menu. Previously it used the generic Debian icon. This PR also adds a prefix to volumes used by Shared FileSystems, again to make them easier to identify among the list of all volumes.
Before:
After:
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 16.14%. Comparing base (
41de0b9) to head (96cb71d). Report is 28 commits behind head on 4.20.
Additional details and impacted files
@@ Coverage Diff @@
## 4.20 #10857 +/- ##
=========================================
Coverage 16.14% 16.14%
- Complexity 13255 13258 +3
=========================================
Files 5657 5657
Lines 497903 497918 +15
Branches 60375 60377 +2
=========================================
+ Hits 80395 80407 +12
- Misses 408549 408552 +3
Partials 8959 8959
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 4.00% <ø> (+<0.01%) |
:arrow_up: |
| unittests | 16.99% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
@blueorangutan ui
@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10857 (QA-JID-644)
@blueorangutan package
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14092
LGTM. Verification passed.
- Instances have a special icon to indicate they are shared file system Instances
- Volumes used by Shared FileSystems have a "shared-" prefix
@blueorangutan package
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14293
@blueorangutan test
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-13839) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 63271 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10857-t13839-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|