cloudstack
cloudstack copied to clipboard
apache
Add logs for storage pools reordering
Description
Since the storage pool reordering process was lacking logs for troubleshooting, some debug level log messages were added and trace level log messages were changed to the debug level. Also, the log messages were rewritten according to the new Log4j2 syntax.
Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
How Has This Been Tested?
- A volume was created;
- Its disk offering was changed;
- It was verified that the log messages were properly being displayed.
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points:
- In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
- Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
- Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
- Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
- Be sure to read the CloudStack Coding Conventions. Apache CloudStack is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] (https://cloudstack.apache.org/mailing-lists.html) Slack: https://apachecloudstack.slack.com/
![boring-cyborg[bot] avatar](https://avatars.githubusercontent.com/in/50386?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
:x: Patch coverage is 20.00000% with 24 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 16.57%. Comparing base (fa85a75) to head (b69581a).
:warning: Report is 332 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...torage/allocator/AbstractStoragePoolAllocator.java | 20.00% | 24 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #10419 +/- ##
============================================
- Coverage 16.58% 16.57% -0.01%
- Complexity 13870 13987 +117
============================================
Files 5719 5745 +26
Lines 507194 510845 +3651
Branches 61573 62136 +563
============================================
+ Hits 84093 84697 +604
- Misses 413681 416676 +2995
- Partials 9420 9472 +52
| Flag | Coverage Δ | |
|---|---|---|
| uitests | 3.91% <ø> (-0.06%) |
:arrow_down: |
| unittests | 17.47% <20.00%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Alright, I've just changed the level of logs on reordering methods, @DaanHoogland
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12691
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13617
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
[SF] Trillian test result (tid-13481) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 57861 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10419-t13481-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
@sureshanaparti , do you think we need anymore testing on this? (/me not convinced)
I've just built the packages locally, so I'm triggering the Blue Orangutan again.
@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
I've just built the packages locally, so I'm triggering the Blue Orangutan again.
why do you think this is needed @julien-vaz ?
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13881
I've just built the packages locally, so I'm triggering the Blue Orangutan again.
why do you think this is needed @julien-vaz ?
Because the debian build has failed previously
why do you think this is needed @julien-vaz ?
Because the debian build has failed previously
ok, nothing related to your changes but now you asked for it ;) @blueorangutan test ubuntu22 kvm-ubuntu22 keepEnv
@DaanHoogland a [SL] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests
[SF] Trillian test result (tid-13665) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 61144 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10419-t13665-kvm-ubuntu22.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
| Test | Result | Time (s) | Test File |
|---|
sorry @julien-vaz , I did some greps on the logs and it all looks fine.
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14158
