cloudstack icon indicating copy to clipboard operation
cloudstack copied to clipboard

pre-commit upgrade codespell and fix spelling

Open jbampton opened this issue 11 months ago • 24 comments

Description

This PR...

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Enhancement (improves an existing feature and functionality)
  • [X] Cleanup (Code refactoring and cleanup, that may add test cases)
  • [ ] build/CI
  • [ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • [ ] Major
  • [ ] Minor

Bug Severity

  • [ ] BLOCKER
  • [ ] Critical
  • [ ] Major
  • [ ] Minor
  • [ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

jbampton avatar Dec 28 '24 09:12 jbampton

Codecov Report

:x: Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 17.56%. Comparing base (ac3b180) to head (56e5e02). :warning: Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...cloud/storage/resource/VmwareStorageProcessor.java 0.00% 9 Missing :warning:
...ava/com/cloud/upgrade/dao/Upgrade41810to41900.java 0.00% 1 Missing :warning:
...oud/hypervisor/vmware/resource/VmwareResource.java 0.00% 1 Missing :warning:
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java 0.00% 1 Missing :warning:
.../java/com/cloud/hypervisor/HypervisorGuruBase.java 0.00% 1 Missing :warning:
...a/com/cloud/storage/StoragePoolAutomationImpl.java 0.00% 1 Missing :warning:
...oud/consoleproxy/ConsoleProxyThumbnailHandler.java 0.00% 1 Missing :warning:
...va/com/cloud/hypervisor/vmware/mo/DatastoreMO.java 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10144   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15534    15540    +6     
=========================================
  Files          5911     5911           
  Lines        529359   529359           
  Branches      64655    64655           
=========================================
+ Hits          92957    92982   +25     
+ Misses       425945   425919   -26     
- Partials      10457    10458    +1     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <23.80%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 28 '24 09:12 codecov[bot]

@blueorangutan package

jbampton avatar Dec 28 '24 11:12 jbampton

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 28 '24 11:12 blueorangutan

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11930

blueorangutan avatar Dec 28 '24 11:12 blueorangutan

@blueorangutan package

DaanHoogland avatar Dec 29 '24 20:12 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Dec 29 '24 20:12 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11939

blueorangutan avatar Dec 29 '24 21:12 blueorangutan

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Jan 08 '25 14:01 github-actions[bot]

@vishesh92 , lgty?

DaanHoogland avatar Apr 26 '25 15:04 DaanHoogland

@blueorangutan package

DaanHoogland avatar Apr 26 '25 15:04 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Apr 26 '25 15:04 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13189

blueorangutan avatar Apr 26 '25 17:04 blueorangutan

@blueorangutan test

DaanHoogland avatar Apr 28 '25 07:04 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Apr 28 '25 07:04 blueorangutan

[SF] Trillian test result (tid-13172) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 54043 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t13172-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_restore_vm_strict_tags_failure Failure 58.55 test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure Failure 58.74 test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure Failure 5.71 test_vm_strict_host_tags.py

blueorangutan avatar Apr 28 '25 23:04 blueorangutan

@vishesh92 are all your concerns met?

DaanHoogland avatar Jun 09 '25 14:06 DaanHoogland

@blueorangutan package

DaanHoogland avatar Jun 09 '25 14:06 DaanHoogland

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Jun 09 '25 14:06 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13674

blueorangutan avatar Jun 09 '25 15:06 blueorangutan

@blueorangutan test

DaanHoogland avatar Jun 11 '25 17:06 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan avatar Jun 11 '25 17:06 blueorangutan

@DaanHoogland @jbampton Since we are changing names of the Command classes, the requests might fail on agents until they are upgraded. IMO this requires some upgrade testing to ensure no issues occur during an upgrade. For a fresh install, there should be no issues.

vishesh92 avatar Jun 12 '25 06:06 vishesh92

[SF] Trillian test result (tid-13501) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 60771 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t13501-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan avatar Jun 12 '25 11:06 blueorangutan

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Jun 16 '25 07:06 github-actions[bot]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions[bot] avatar Jul 29 '25 13:07 github-actions[bot]

@blueorangutan package

jbampton avatar Sep 16 '25 16:09 jbampton

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan avatar Sep 16 '25 16:09 blueorangutan

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15040

blueorangutan avatar Sep 16 '25 19:09 blueorangutan

@blueorangutan test matrix

DaanHoogland avatar Sep 17 '25 10:09 DaanHoogland

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan avatar Sep 17 '25 10:09 blueorangutan