apache
Update VMwareTrafficLabel for vSwitch type handling
This update involves removing the traffic shaping functionality from the system. Previously, traffic shaping was being applied to control the flow of data across the network, but after careful consideration, it was determined that this mechanism was no longer necessary for the current system requirements.
Reason for Removing Traffic Shaping: The decision to remove traffic shaping was based on the following factors:
Ineffective for Current Needs: Traffic shaping was not aligned with the present system's architecture, and it was causing unnecessary complexity without offering significant benefits to the network performance. Performance Overhead: The traffic shaping process added unnecessary computational overhead, which negatively impacted the overall system performance. Removing it helps streamline the operations and reduces the load. Shift in System Requirements: As the system evolved, the need for fine-tuned traffic management decreased. With the current configuration, it was concluded that other optimizations could handle the network traffic more efficiently. Simplification of Codebase: Removing traffic shaping simplifies the codebase, making it more maintainable and easier to troubleshoot in the future. By removing this feature, we aim to improve performance and simplify the system, while ensuring that other network management mechanisms continue to function effectively.
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13622
@iishitahere, closing this one as it is old. please update and reopen if you think it is still relevant.
Hi @DaanHoogland, Understood. I’ll review the current VMware networking code to verify whether the original issues around secondary NIC traffic shaping and vm.network.throttling.rate handling still exist with the updated architecture.
If the fix is still applicable, I’ll update the patch and reopen the PR. Otherwise, I’ll confirm that it can be closed permanently.
Ishita